Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle.bbclass: support manifest generation for artifacts #337

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

jluebbe
Copy link
Member

@jluebbe jluebbe commented Aug 7, 2024

This is useful only in combination with the upcoming support for artifacts, but shouldn't hurt the standard case for now.

@jluebbe jluebbe added the master label Aug 7, 2024
@jluebbe jluebbe requested a review from ejoerns August 7, 2024 12:39
classes-recipe/bundle.bbclass Outdated Show resolved Hide resolved
classes-recipe/bundle.bbclass Show resolved Hide resolved
classes-recipe/bundle.bbclass Show resolved Hide resolved
@ejoerns
Copy link
Member

ejoerns commented Nov 15, 2024

I've added the changes that I needed to make this work. I don't think it makes much sense to merge this without having the pseudo/fakeroot setup working correctly. Except for the documentation, the changes are only related to conversion for adaptive updates anyway.

What would still be needed probably is to remove the now potentially useless pseudo handling for casync and check for potential breakage of use cases due to the added fakeroot to do_bundle().

@ejoerns
Copy link
Member

ejoerns commented Nov 15, 2024

Rebased onto master to send this through the CI workflow.

ejoerns and others added 2 commits January 22, 2025 10:37
With the upcoming artifacts support, we have the need to either use
a real 'fakeroot' or to run in a pseudo-enabled task to support e.g. the
tar conversion mode.

Since OE does not provide a fakeroot recipe and running a task
pseudo-enabled is a built-in bitbake feature, we simply use it.

The only issue with that so far was that casync bundle conversion
unconditionally called 'fakeroot' from within RAUC and that this
conflicts with the pseudo-enabled task.
This was resolved now in rauc/rauc#1603 by
making the 'fakeroot' call conditional (on not running under pseudo).

This also allows us to drop the usage of 'pseudo' as a fakeroot
replacement for casync, which simplifies the 'rauc convert' call.

Signed-off-by: Enrico Jörns <[email protected]>
This is useful only in combination with the upcoming support for
artifacts, but shouldn't hurt the standard case for now.

Signed-off-by: Jan Luebbe <[email protected]>
Signed-off-by: Enrico Jörns <[email protected]>
@ejoerns
Copy link
Member

ejoerns commented Jan 22, 2025

I've added the changes that I needed to make this work. I don't think it makes much sense to merge this without having the pseudo/fakeroot setup working correctly. Except for the documentation, the changes are only related to conversion for adaptive updates anyway.

What would still be needed probably is to remove the now potentially useless pseudo handling for casync and check for potential breakage of use cases due to the added fakeroot to do_bundle().

This is fixed now by rauc/rauc#1603 and I've added a seperate commit to enable pseudo and drop the old pseudo/fakeroot handling for casync.

@ejoerns ejoerns removed their assignment Jan 22, 2025
Copy link
Member Author

@jluebbe jluebbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me now.

@ejoerns ejoerns merged commit 4f2cbd5 into rauc:master Jan 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants