-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bundle.bbclass: support manifest generation for artifacts #337
Conversation
78a6e40
to
2fd6077
Compare
I've added the changes that I needed to make this work. I don't think it makes much sense to merge this without having the pseudo/fakeroot setup working correctly. Except for the documentation, the changes are only related to conversion for adaptive updates anyway. What would still be needed probably is to remove the now potentially useless pseudo handling for casync and check for potential breakage of use cases due to the added |
2fd6077
to
ebafcff
Compare
Rebased onto master to send this through the CI workflow. |
With the upcoming artifacts support, we have the need to either use a real 'fakeroot' or to run in a pseudo-enabled task to support e.g. the tar conversion mode. Since OE does not provide a fakeroot recipe and running a task pseudo-enabled is a built-in bitbake feature, we simply use it. The only issue with that so far was that casync bundle conversion unconditionally called 'fakeroot' from within RAUC and that this conflicts with the pseudo-enabled task. This was resolved now in rauc/rauc#1603 by making the 'fakeroot' call conditional (on not running under pseudo). This also allows us to drop the usage of 'pseudo' as a fakeroot replacement for casync, which simplifies the 'rauc convert' call. Signed-off-by: Enrico Jörns <[email protected]>
This is useful only in combination with the upcoming support for artifacts, but shouldn't hurt the standard case for now. Signed-off-by: Jan Luebbe <[email protected]> Signed-off-by: Enrico Jörns <[email protected]>
ebafcff
to
2487a4c
Compare
This is fixed now by rauc/rauc#1603 and I've added a seperate commit to enable pseudo and drop the old pseudo/fakeroot handling for casync. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me now.
This is useful only in combination with the upcoming support for artifacts, but shouldn't hurt the standard case for now.