Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-release 4 branch merge #59

Merged
merged 9 commits into from
Feb 28, 2020
Merged

pre-release 4 branch merge #59

merged 9 commits into from
Feb 28, 2020

Conversation

o-smirnov
Copy link
Contributor

No description provided.

@o-smirnov o-smirnov requested a review from Athanaseus February 27, 2020 19:55
@o-smirnov
Copy link
Contributor Author

@Athanaseus, I made a 1.0-pre4 release (turns out you can release off a branch too, not just off master), could you please make sure it goes into PyPI? Once it's there, I can test the 1.0-pre4 client.

Copy link
Member

@Athanaseus Athanaseus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Just minor comments.


message("Activating virtualenv")
with open(activation_script) as f:
code = compile(f.read(), activation_script, 'exec')
exec(code, dict(__file__=activation_script), {})

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some white space over here

@Athanaseus
Copy link
Member

@Athanaseus, I made a 1.0-pre4 release (turns out you can release off a branch too, not just off master), could you please make sure it goes into PyPI? Once it's there, I can test the 1.0-pre4 client.

Awesome! Yep, that went through.
PS: I'll do a test install

@o-smirnov o-smirnov merged commit 8407e2f into master Feb 28, 2020
@Athanaseus
Copy link
Member

The installation seems to work for me!

@o-smirnov
Copy link
Contributor Author

Excellent! I'm still having some trouble with remote deployments, but I have to work on something else now. Will get back to this over the next day or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants