Retain ROWID coordinates during MS conversion (#286)

ratt-ru · Sep 14, 2023 · 9351e14 · 9351e14
1 parent b239b35
commit 9351e14
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/daskms/apps/convert.py b/daskms/apps/convert.py
@@ -228,10 +228,6 @@ def convert_table(self, args):
 
         datasets = reader(args.input, chunks=args.chunks)
 
-        if isinstance(in_fmt, CasaFormat):
-            # Drop any ROWID columns
-            datasets = [ds.drop_vars("ROWID", errors="ignore") for ds in datasets]
-
         if exclude_columns := args.exclude.get("MAIN", False):
             datasets = [
                 ds.drop_vars(exclude_columns, errors="ignore") for ds in datasets
@@ -273,9 +269,6 @@ def convert_table(self, args):
                     ds.drop_vars(exclude_columns, errors="ignore") for ds in datasets
                 ]
 
-            if isinstance(in_fmt, CasaFormat):
-                datasets = [ds.drop_vars("ROWID", errors="ignore") for ds in datasets]
-
             writes.append(writer(datasets, out_store))
 
         return writes
diff --git a/daskms/apps/tests/test_convert.py b/daskms/apps/tests/test_convert.py
@@ -49,6 +49,7 @@ def test_convert_application(tau_ms, format, tmp_path_factory):
     for ds in datasets:
         assert "MODEL_DATA" not in ds.data_vars
         assert "FLAG" in ds.data_vars
+        assert "ROWID" in ds.coords
 
     datasets = xds_from_storage_table(f"{str(OUTPUT)}::POINTING")