cubical 1.5.8 release #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
P.S. I uploaded the image to quay.io. In the interregnum, I probably need to upload to docker.io too, right? |
|
As a freshman with his first cab just submitted I'd upvote the suggestion of Oleg's. The great benefit would be that two different images would not be tagged with the same tag twice (depending of the morale of the tagger, of course). That would be really great for the user (which I have been for a long time now). |
|
I'm not so sure I support the suggestion. I prefer the upload only as
needed policy where the image version numbers only increase when the image
actually changes. Otherwise there is a lot of very expensive duplication of
singularity images.
Can you perhaps roll back the image to that of the previous commit Oleg?
…On Tue, 26 Jan 2021, 23:35 Sphesihle Makhathini, ***@***.***> wrote:
Merged #691 <#691> into master.
—
u are receiving this because you are subscribed to this thrad
Reply to this email directly, view it on GitHub
<#691 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4RE6SYOXUDFJMFDGTRSYDS34YS3ANCNFSM4UWOVH5Q>.
pre
|
|
It is perhaps better to keep a central manifest with the current version
numbers which we can bump as needed along with a centralized image build
command so that this process is not manual. It can check if the image tag
exist (via a request json to the hub) and only push if the version tag does
not exist.
…On Wed, 27 Jan 2021, 01:19 Benna Hugo, ***@***.***> wrote:
I'm not so sure I support the suggestion. I prefer the upload only as
needed policy where the image version numbers only increase when the image
actually changes. Otherwise there is a lot of very expensive duplication of
singularity images.
Can you perhaps roll back the image to that of the previous commit Oleg?
On Tue, 26 Jan 2021, 23:35 Sphesihle Makhathini, ***@***.***>
wrote:
> Merged #691 <#691> into master.
>
> —
> u are receiving this because you are subscribed to this thrad
> Reply to this email directly, view it on GitHub
> <#691 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AB4RE6SYOXUDFJMFDGTRSYDS34YS3ANCNFSM4UWOVH5Q>.
> prei
>
|
|
Yep, that's exactly the point of #692. On it already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous cubical base image was tagged 1.6.7. I'm sorry, I tried to make an image tagged 1.6.8 containing CubiCal release 1.5.8, but a little OCD homunculus inside me woke up, stomped its feet and shouted, "No more! Cannot take! Consistent versions matter!"
So I gave in, and tagged the new image 1.5.8. If there's a secret user community out there using vintage 1.5.8 images (containing CubiCal release 1.3.6, no doubt...), they've just been royally and callously screwed. Sorrynotsorry.
Seriously though, may I suggest we slowly gravitate to a situation where Stimela image tags follow the underlying package version (at least for "single malt" cabs such as e.g. cubical and wsclean)? This may mean revising some tags "down", as is the case here, but that's ok, right?