-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subtle misc. refactors and lint suggestions #104
Conversation
c10882d
to
005bbfc
Compare
The previous CI error is because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! There are a couple changes I'd like to see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mwtoews ! Anything else?
I think that's it! Expect a docstyle PR soonish. |
This PR has several miscellaneous refactors and applied lint suggestions via
ruff check
rules:Apply pydocstyle rules with "google" convention; these changes were mostly automated with a few manual edits for line lengthsformat()
instead of%
formatspytest.approx()
rather thanassert round(...
expressionsThe only subtle change in this PR that is arguably not a refactor is to
__new__
, which will enforcefloat
types. For instance, before this was the behavior:now with this PR the properties are all Python-native
float
types.