Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit with ruff, and other checks (EOL, trailing whitespace) #102

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Sep 12, 2024

This adds a pre-commit configuration that migrates a few tools:

  • Add check-yaml, end-of-file-fixer and trailing-whitespace with a few expected changes
  • Add Ruff linter and formatter, which has a few minor changes to the main source code
  • Migrate pydocstyle and flake8 (pycodestyle, pyflakes) configuration to Ruff linter
  • Remove setup.cfg, as the configuration is moved and pytest doesn't need any
  • Remove CI jobs "lint" and "typing"
  • Add a CI job "pre-commit" to run; however I highly recommend https://pre-commit.ci to be configured for this repo instead
  • the "dev" optional install list is nearly empty, and I think it could be removed (not done here yet)

@mwtoews
Copy link
Contributor Author

mwtoews commented Dec 18, 2024

ping @sgillies for review

Copy link
Member

@sgillies sgillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mwtoews !

@sgillies sgillies merged commit ea09e59 into rasterio:main Dec 18, 2024
7 checks passed
@mwtoews mwtoews deleted the pre-commit branch December 18, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants