Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Allow OS maintainer to use their own video mode settings. Fixes #259 #263

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samnazarko
Copy link

This should resolve #259.

  • This lets the OS maintainer define "managevideo": "1" in the os.json file if they wish to handle the video modes.
  • If this value is not set, or the value is 0, the old behaviour will be unchanged and the 'videomode' from the QVariantMap will be used to populate the config.txt accordingly.

@samnazarko
Copy link
Author

@lurch Have you had a chance to look at this yet?

@lurch
Copy link
Collaborator

lurch commented Jul 8, 2015

Nope, been too busy with other stuff, sorry.

@NicoHood
Copy link

NicoHood commented Feb 6, 2016

I've updated the patch and merged it into my personal nicohood branch.
59d1496

Ive tested it and it works fine. I really like the idea, since noobs always gets in the way of my monitor settings.

Do not merge this PR, it requires some more changes that I made in my commit. Please refer to the commit above instead.

@samnazarko
Copy link
Author

I can update my original commit to include your changes.

@NicoHood
Copy link

NicoHood commented Feb 6, 2016

Please do so. I really like to see this one merged.

@samnazarko
Copy link
Author

I have updated my PR against master.

@NicoHood
Copy link

NicoHood commented Feb 6, 2016

You forgot to declare bool _managevideo;. Have a look at my commit again ;)

@samnazarko
Copy link
Author

Updated now. Did this in a hurry so have not compile tested.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leave config.txt options to the maintainer
3 participants