Fixed passing in title props, Keyextractor warning #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new prop openText, which will allow users to change the way their text is displayed Fixed passing in props where before the title prop did not work, Added a close button
|
@Thomasznguyen Thanks so much for the PR! I was thinking if we could make it a bit more flexible though. For example, instead of just using a text label, what someone wants to have an icon or a button which will trigger the picker. so probably there should a way to pass a view in place of the title. can you take a look at it? thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new prop openText, which will allow users to change the way their text is displayed
Fixed passing in props where before the title prop did not work,
Added a close button