Optimize euclidian distance in raft refine phase #2574
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial issue
Originally written code (below) generated serial assembly and used strictly-ordered
fadda
instructions (at least on gcc & clang). That resulted in suboptimal performance.Proposed solution
This PR provides optimized generic reduction using used partial vector sum (below), that helps vectorization but looses strcictly-ordered limitation.
Also it adds NEON implementation with intrinsics which provided further speedup on certain test cases (can be removed if arch-specific code is undesired).
Results