Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take argument by const& as the input range is const #2558

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Take argument by const& as the input range is const #2558

merged 1 commit into from
Feb 6, 2025

Conversation

miscco
Copy link
Contributor

@miscco miscco commented Jan 30, 2025

Found breaking CCCL ci

@miscco miscco requested a review from a team as a code owner January 30, 2025 16:27
@github-actions github-actions bot added the cpp label Jan 30, 2025
@miscco miscco force-pushed the fix_ball_cover_test branch from c29f5ec to 3424363 Compare February 6, 2025 07:15
@miscco miscco requested review from a team as code owners February 6, 2025 07:15
@miscco miscco requested a review from gforsyth February 6, 2025 07:15
@miscco miscco changed the base branch from branch-25.02 to branch-25.04 February 6, 2025 07:15
@KyleFromNVIDIA KyleFromNVIDIA removed request for a team February 6, 2025 14:39
KyleFromNVIDIA
KyleFromNVIDIA approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed extraneous reviewers and approved

@KyleFromNVIDIA KyleFromNVIDIA added bug Something isn't working non-breaking Non-breaking change labels Feb 6, 2025
@KyleFromNVIDIA
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit a436257 into rapidsai:branch-25.04 Feb 6, 2025
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@KyleFromNVIDIA KyleFromNVIDIA KyleFromNVIDIA approved these changes

@gforsyth gforsyth Awaiting requested review from gforsyth gforsyth was automatically assigned from rapidsai/packaging-codeowners

Assignees
No one assigned
Labels
bug Something isn't working cpp non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miscco @KyleFromNVIDIA @dantegd