Review updates

* review updates --------- Co-authored-by: Vivek Narang <[email protected]>
rapidsai · Jan 8, 2025 · 72bc6e3 · 72bc6e3
1 parent 2c0e4cd
commit 72bc6e3
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 12 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,6 +1,5 @@
 ## common
 __pycache__
-.gitignore
 *.pyc
 *~
 \#*

diff --git a/build.sh b/build.sh
@@ -455,10 +455,12 @@ fi
 
 # Build the cuvs Java bindings 
 if (( ${NUMARGS} == 0 )) || hasArg java; then
+    # build libcuvs first as the Java API depends on it
+    ./$0 libcuvs
     cd ${REPODIR}/java
     ./build.sh
-fi 
-   
+fi
+
 export RAPIDS_VERSION="$(sed -E -e 's/^([0-9]{2})\.([0-9]{2})\.([0-9]{2}).*$/\1.\2.\3/' "${REPODIR}/VERSION")"
 export RAPIDS_VERSION_MAJOR_MINOR="$(sed -E -e 's/^([0-9]{2})\.([0-9]{2})\.([0-9]{2}).*$/\1.\2/' "${REPODIR}/VERSION")"
 

diff --git a/java/README.md b/java/README.md
@@ -4,8 +4,10 @@ Prerequisites
 * JDK 22
 * Maven 3.9.6 or later
 
-Please build libcuvs (`./build.sh libcuvs` from top level directory) before building the Java API with `./build.sh` from this directory. 
+To build this API, please do `./build.sh java` in the top level directory. Since this API is dependent on `libcuvs` it must be noted that `libcuvs` gets built automatically before building this API.
 
+Alternatively, please build libcuvs (`./build.sh libcuvs` from top level directory) before building the Java API with `./build.sh` from this directory.
+
 Building
 --------
 

diff --git a/java/build.sh b/java/build.sh
@@ -1,5 +1,3 @@
-export CMAKE_PREFIX_PATH=`pwd`/../cpp/build
-
 VERSION="25.02"
 GROUP_ID="com.nvidia.cuvs"
 SO_FILE_PATH="./internal"

diff --git a/java/cuvs-java/src/main/java/module-info.java b/java/cuvs-java/src/main/java/module-info.java
@@ -1,10 +1,9 @@
 /*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
+ * Copyright (c) 2025, NVIDIA CORPORATION.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
  *
  *     http://www.apache.org/licenses/LICENSE-2.0
  *