Skip to content

Commit

Permalink
Reduce the recall threshold for IVF-PQ low-precision LUT inner produc…
Browse files Browse the repository at this point in the history
…t tests (#573)

IVF-PQ allows to use low-precision for the lookup table during search to improve QPS. When used for the inner product distance, this has extra tall on recall. This PR reduces our expectation of the recall in this case as an answer to occasional test failures in CI.

Authors:
  - Artem M. Chirkin (https://github.com/achirkin)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #573
  • Loading branch information
achirkin authored Jan 16, 2025
1 parent 898ccfb commit 47d71c3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cpp/test/neighbors/ann_ivf_pq.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -879,7 +879,7 @@ inline auto enum_variety_ip() -> test_cases_t
// InnerProduct score is signed,
// thus we're forced to used signed 8-bit representation,
// thus we have one bit less precision
y.min_recall = y.min_recall.value() * 0.90;
y.min_recall = y.min_recall.value() * 0.88;
} else {
// In other cases it seems to perform a little bit better, still worse than L2
y.min_recall = y.min_recall.value() * 0.94;
Expand Down

0 comments on commit 47d71c3

Please sign in to comment.