Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Treelite to 4.4.1 #6212

Merged
merged 4 commits into from
Jan 31, 2025
Merged

Bump Treelite to 4.4.1 #6212

merged 4 commits into from
Jan 31, 2025
+9 −9

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Jan 8, 2025

Treelite 4.4.1 contains the following improvements and fixes:

@hcho3 hcho3 requested review from a team as code owners January 8, 2025 01:58
@github-actions github-actions bot added conda conda issue Cython / Python Cython or Python issue CMake CUDA/C++ labels Jan 8, 2025
@hcho3 hcho3 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 8, 2025
jameslamb
jameslamb approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hcho3 are you hoping to get this into 25.02? We should try to merge it as soon as possible, to have time to discover new issues ahead of 25.02 code freeze.

Giving you a packaging-codeowners approval, and I've manually restarted CI by merging latest branch-25.02 in.

@jameslamb jameslamb removed the request for review from gforsyth January 28, 2025 23:36
This was referenced Jan 30, 2025
Open
Closed
@betatim
Copy link
Member

betatim commented Jan 30, 2025

Some of the CI failures are probably related to a change in cudf, but some of them (https://github.com/rapidsai/cuml/actions/runs/13043996912/job/36393848975?pr=6212) are related to converting from cupy to numpy in random forest specific tests. Something to look at/fix in this PR

@hcho3
Copy link
Contributor Author

hcho3 commented Jan 31, 2025

I'm not able to locally reproduce the error. It appears that the same error is affecting other tests too.

@hcho3
Copy link
Contributor Author

hcho3 commented Jan 31, 2025 •
edited
Loading

Re-running tests to use latest dev version of dask-cudf (25.02.00a352 -> 25.02.00a360). The CI job was using a352, whereas locally I am using a360.

@betatim
Copy link
Member

betatim commented Jan 31, 2025

Great success! Thanks for figuring it out

@betatim
Copy link
Member

betatim commented Jan 31, 2025

Do we still merge this into 25.02 or retarget 25.04?

@hcho3
Copy link
Contributor Author

hcho3 commented Jan 31, 2025

We should merge this for 25.02.

@betatim
Copy link
Member

betatim commented Jan 31, 2025

/merge

@hcho3
Copy link
Contributor Author

hcho3 commented Jan 31, 2025

We need an approval from a CMake codeowner.

@rapids-bot rapids-bot bot merged commit 69c41c4 into rapidsai:branch-25.02 Jan 31, 2025
70 checks passed
@hcho3 hcho3 deleted the bump_treelite branch January 31, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@betatim betatim betatim approved these changes

@dantegd dantegd dantegd approved these changes

@KyleFromNVIDIA KyleFromNVIDIA Awaiting requested review from KyleFromNVIDIA KyleFromNVIDIA is a code owner automatically assigned from rapidsai/cuml-cmake-codeowners

Assignees
No one assigned
Labels
CMake conda conda issue CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hcho3 @betatim @dantegd @jameslamb