Remove cudf._libs.types.pyx #17665
Open
Remove cudf._libs.types.pyx #17665
+255
−319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
wence-
requested changes
Jan 7, 2025
python/cudf/cudf/_lib/column.pyx
Outdated
| @@ -64,6 +62,80 @@ cdef get_element(column_view col_view, size_type index): | |||
| ) | |||
|
|
|||
|
|
|||
| def dtype_from_pylibcudf_column(col): | |||
There was a problem hiding this comment.
Suggested change
| def dtype_from_pylibcudf_column(col): | |
| def dtype_from_pylibcudf_column(Column col not None): |
| @@ -424,7 +496,7 @@ cdef class Column: | |||
| col = self | |||
| data_dtype = col.dtype | |||
|
|
|||
| cdef plc_DataType dtype = dtype_to_pylibcudf_type(data_dtype) | |||
| cdef plc_DataType dtype = <plc_DataType>dtype_to_pylibcudf_type(data_dtype) | |||
There was a problem hiding this comment.
Suggested change
| cdef plc_DataType dtype = <plc_DataType>dtype_to_pylibcudf_type(data_dtype) | |
| cdef plc_DataType dtype = <plc_DataType?>dtype_to_pylibcudf_type(data_dtype) |
I think we want this to be a fallible cast.
| ) | ||
| elif cdtype_id == plc.TypeID.STRUCT: | ||
| self._dtype = StructDtype.from_arrow( | ||
| plc.interop.to_arrow(self.c_value).type |
There was a problem hiding this comment.
nit: This now necessitates a device to host copy and synchronisation just to get the type (which is a host-side thing).
There was a problem hiding this comment.
Yeah I was hoping that this would be temporarily OK as I'm aiming remove DeviceScalar (along with this code) by the next release cc @vyasr
| plc.interop.to_arrow(self.c_value).type | ||
| ) | ||
| elif cdtype_id == plc.TypeID.LIST: | ||
| self._dtype = ListDtype.from_arrow(plc.interop.to_arrow(self.c_value).type) |
There was a problem hiding this comment.
nit: same issue here as with structs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #17317
cudf/utils/dtypes.pycudf/_libs/column.pyxChecklist