-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix incorrect wallet state after switch account #989
Open
RyukTheCoder
wants to merge
1
commit into
next
Choose a base branch
from
fix/rf-2141-fix-incorrect-wallet-state-after-switch-account
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: fix incorrect wallet state after switch account #989
RyukTheCoder
wants to merge
1
commit into
next
from
fix/rf-2141-fix-incorrect-wallet-state-after-switch-account
+29
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeager-eren
reviewed
Jan 20, 2025
yeager-eren
reviewed
Jan 20, 2025
yeager-eren
reviewed
Jan 20, 2025
RyukTheCoder
force-pushed
the
fix/rf-2141-fix-incorrect-wallet-state-after-switch-account
branch
from
January 22, 2025 09:57
fd44498
to
355c9ee
Compare
yeager-eren
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
RyukTheCoder
force-pushed
the
fix/rf-2141-fix-incorrect-wallet-state-after-switch-account
branch
from
January 26, 2025 12:47
fc917ac
to
4c36254
Compare
RyukTheCoder
force-pushed
the
fix/rf-2141-fix-incorrect-wallet-state-after-switch-account
branch
2 times, most recently
from
January 26, 2025 15:40
bdfd9f6
to
e2e03c1
Compare
RyukTheCoder
force-pushed
the
fix/rf-2141-fix-incorrect-wallet-state-after-switch-account
branch
from
January 26, 2025 16:16
eb6d01c
to
62c0252
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses an inconsistency related to disconnecting Phantom wallets after switching to an account that does not contain both Solana and EVM addresses. Previously, when transitioning from an account with both addresses to one containing only the EVM address, only the Solana account would disconnect. Conversely, moving from an account with both addresses to one with only the Solana address resulted in both Solana and EVM accounts disconnecting.
This PR resolves the issue by ensuring that when switching from an account containing both addresses to one with only either the EVM or Solana address, only the connection to the unavailable address is disconnected. This enhancement provides a more coherent and expected behavior during account transitions.
Fixes # 2141
How did you test this change?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: