fix: fix wallet button state in swap details page #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
widget/embedded/src/components/SwapDetailsModal/SwapDetailsModal.WalletState.tsx
Outdated
Show resolved
Hide resolved
samobasquiat
approved these changes
Dec 13, 2023
RanGojo
requested review from
yeager-eren and
RanGojo
and removed request for
yeager-eren
RanGojo
approved these changes
Dec 18, 2023
Ikari-Shinji-re
force-pushed
the
fix/fix-connect-wallet-button-state-in-swap-details-page
branch
from
d9659f6 to
8159216
Compare
RanGojo
deleted the
fix/fix-connect-wallet-button-state-in-swap-details-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On Swap page, when we are showing the button for connecting the required wallet, if you click on connect wallet twice (when the wallet is on connecting state), it will crash.
We should disable the button, when we are connecting the wallet.
Fixes # (issue)
pass wallet-core state to wallet button
How did you test this change?
On Swap page, when we are showing the button for connecting the required wallet, if you click on connect wallet twice (when the wallet is on connecting state), It should not prompt any errors.