fix: fix bug of not publishing language files in npm #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I encountered an error within the Resolved! |
mikasackermn
force-pushed
the
fix/rf-1048-publishing-language
branch
from
3a30c25 to
1577fb0
Compare
samobasquiat
reviewed
Dec 5, 2023
samobasquiat
approved these changes
Dec 5, 2023
|
Not needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Language files inside /translations/* should be published with embedded as well, if not, it will not work properly.
I tested with our own code, there was no problem, I just transferred I18NManager to the widget (because it is used in the widget).
How did you test this change?
Serve Playground and change the language
Checklist: