Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!WIP fix: fix wallet connect cosmos #456

Closed
wants to merge 1 commit into from

Conversation

RanGojo
Copy link
Member

@RanGojo RanGojo commented Nov 26, 2023

Summary

In this PR, I've fixed problem related to supporting wallet connect for cosmos based blockchains.

How did you test this change?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test an amino tx on osmosis using trust wallet app
  • Test a direct tx on osmosis using trust wallet app

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

@RanGojo RanGojo marked this pull request as draft November 26, 2023 18:43
@RanGojo RanGojo closed this Feb 27, 2024
@RanGojo RanGojo deleted the fix/fix-wallet-connect-cosmos branch August 20, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant