Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove unnecessary files & logics in playground #453

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

mikasackermn
Copy link
Collaborator

@mikasackermn mikasackermn commented Nov 25, 2023

Summary

We had unnecessary files and logic in the Playground that had to be removed

How did you test this change?

Run Playground

Checklist:

  • I have performed a self-review of my code

Sorry, something went wrong.

@samobasquiat
Copy link
Member

samobasquiat commented Nov 25, 2023

I saw some errors or files that have not been resolved (removed):

  • import type { MapSupportedList } from './MultiList.types'; in widget/playground/src/components/MultiList/MultiList.helper.ts
  • widget/playground/src/components/MultiSelect/MultiTokenSelect.tsx
  • widget/playground/src/components/MultiSelect/index.tsx
  • widget/playground/src/components/MultiSelect/Container.tsx
  • SearchParams in widget/playground/src/constants/index.ts
  • // import { LiquiditiesSection } from './FunctionalLayout.Liquidities';
  • Do we still need /* eslint-disable @typescript-eslint/no-magic-numbers */ ? I didn't see any number in that file.
  • After removing multi-select I think we can remove containsText & filterTokens as well
  • Can you check package json file as well?

Sorry, something went wrong.

@mikasackermn mikasackermn force-pushed the feat/rf-1003-remove-unnecessary-files-logics branch from d3645b6 to 4219810 Compare November 25, 2023 13:36
@RanGojo RanGojo changed the title feat(playground-v2): remove unnecessary files & logics in playground feat: remove unnecessary files & logics in playground Nov 26, 2023
@RanGojo RanGojo self-requested a review November 29, 2023 09:33
@RanGojo
Copy link
Member

RanGojo commented Dec 3, 2023

It seems good to me. @mikasackermn Please syn with the next so I will perform a final test.

@mikasackermn mikasackermn force-pushed the feat/rf-1003-remove-unnecessary-files-logics branch 2 times, most recently from c139ed1 to dda3b6a Compare December 3, 2023 06:17
@mikasackermn mikasackermn requested a review from RanGojo December 3, 2023 10:17
@mikasackermn mikasackermn force-pushed the feat/rf-1003-remove-unnecessary-files-logics branch from 65f4e61 to 61c1779 Compare December 3, 2023 11:06
@mikasackermn mikasackermn force-pushed the feat/rf-1003-remove-unnecessary-files-logics branch from 61c1779 to 29f5bc6 Compare December 3, 2023 11:07
@RanGojo RanGojo merged commit a1b74cc into next Dec 3, 2023
@RanGojo RanGojo deleted the feat/rf-1003-remove-unnecessary-files-logics branch December 3, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants