Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix performance issues on token selector in widget #451

Merged

Conversation

Ikari-Shinji-re
Copy link
Member

@Ikari-Shinji-re Ikari-Shinji-re commented Nov 22, 2023

Summary

When a wallet is connected, navigation for choosing swap items, and the process of selecting blockchains experiences delays.

Fixes # (issue)

  • improve getting the balance performance
  • running expensive logic only if the total balance changed

How did you test this change?

connect a wallet and change the selected blockchain

Checklist:

  • connecting and disconnecting a wallet should update the tokens correctly
  • smooth transition to select swap item page

@Ikari-Shinji-re Ikari-Shinji-re force-pushed the fix/rf-1043-fix-performance-issues-on-token-selector branch from 4911586 to f813fd5 Compare November 22, 2023 06:52
@RanGojo RanGojo self-requested a review November 22, 2023 08:24
widget/embedded/src/store/slices/data.ts Outdated Show resolved Hide resolved
widget/embedded/src/utils/wallets.ts Outdated Show resolved Hide resolved
widget/embedded/src/utils/wallets.ts Outdated Show resolved Hide resolved
widget/embedded/src/utils/wallets.ts Outdated Show resolved Hide resolved
widget/embedded/src/utils/wallets.ts Outdated Show resolved Hide resolved
widget/embedded/src/utils/wallets.ts Outdated Show resolved Hide resolved
widget/embedded/src/utils/wallets.ts Show resolved Hide resolved
widget/embedded/src/pages/Home.tsx Outdated Show resolved Hide resolved
widget/embedded/src/types/wallets.ts Outdated Show resolved Hide resolved
widget/embedded/src/utils/wallets.ts Outdated Show resolved Hide resolved
widget/embedded/src/utils/wallets.ts Outdated Show resolved Hide resolved
widget/embedded/src/utils/wallets.ts Show resolved Hide resolved
@RanGojo RanGojo requested a review from yeager-eren November 29, 2023 09:32
@yeager-eren
Copy link
Collaborator

We missed the 0 amount.
Screenshot

@Ikari-Shinji-re Ikari-Shinji-re force-pushed the fix/rf-1043-fix-performance-issues-on-token-selector branch from 7430c22 to 1e04c79 Compare December 3, 2023 07:50
@yeager-eren yeager-eren merged commit ea0b1be into next Dec 3, 2023
1 check passed
@yeager-eren yeager-eren deleted the fix/rf-1043-fix-performance-issues-on-token-selector branch December 3, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants