fix(wallets): fix switch network bug in wallet connect #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
RanGojo
commented
Nov 12, 2023
•
RanGojo
commented
- handle switch network without creating new session
- fix minor bugs in subscribe
- update manifest
- handle async/sync switch network state update
- update wallet-connect deps to the latest version
yeager-eren
reviewed
Nov 12, 2023
| @@ -126,12 +132,18 @@ export const subscribe: Subscribe = ({ | |||
| // Listen to events triggred by wallet. (e.g. accountsChanged and chainChanged) | |||
| client.on('session_event', (args) => { | |||
| if (args.params.event.name === EthereumEvents.ACCOUNTS_CHANGED) { | |||
| const accounts = args.params.event.data; | |||
| const chainId = args.params.chainId; | |||
| const accounts = args.params.event.data.map((account: string) => { | |||
There was a problem hiding this comment.
Please use caip package for working with CAIP standard.
| @@ -192,3 +201,76 @@ export function getChainIdByNetworkName( | |||
|
|
|||
| return chainId; | |||
| } | |||
|
|
|||
| export async function switchOrAddEvmChain( | |||
There was a problem hiding this comment.
Please use caip package for working with CAIP standard.
It can parse and also generate the string. Please make sure you are using it in this function.
| }); | ||
| instance.session = session; | ||
| const isAsyncSwitchNetork = needSessionRecreateOnSwitchNetwork(instance); | ||
| config.isAsyncInstance = true; |
| */ | ||
| if ( | ||
| requestedNetwork !== this.state.network && | ||
| !this.options.config.isAsyncSwitchNetwork |
There was a problem hiding this comment.
To make it more general I suggest change it to something like this:
this.options.config.avoidUpdateOnSwitchNetwork({
instance: this.provider,
network: requestedNetwork,
getState: this.getState.bind(this),
})
There was a problem hiding this comment.
I will fix this comment and next related ones in my next PR.
| const isAsyncSwitchNetork = needSessionRecreateOnSwitchNetwork(instance); | ||
| config.isAsyncInstance = true; | ||
| if (isAsyncSwitchNetork) { | ||
| config.isAsyncSwitchNetwork = false; |
There was a problem hiding this comment.
if you've implemented avoidUpdateOnSwitchNetwork, you can remove this line from here.
| meta, | ||
| }); | ||
| instance.session = session; | ||
| const isAsyncSwitchNetork = needSessionRecreateOnSwitchNetwork(instance); |
There was a problem hiding this comment.
you can directly call your function (as avoidUpdateOnSwitchNetwork) here as well.
RanGojo
force-pushed
the
fix/fix-wallet-connect-switch-network
branch
from
8873683 to
f60f65a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.