-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(widget): handle wallet referrer in widget #431
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikasackermn
force-pushed
the
feat/rf-997-handle-wallet-referrer
branch
from
November 11, 2023 07:44
5fc13a2
to
ca9cb65
Compare
Ikari-Shinji-re
approved these changes
Nov 11, 2023
RanGojo
reviewed
Nov 15, 2023
mikasackermn
force-pushed
the
feat/rf-997-handle-wallet-referrer
branch
from
November 18, 2023 09:00
88c93f0
to
a220e96
Compare
RanGojo
approved these changes
Nov 18, 2023
mikasackermn
force-pushed
the
feat/rf-997-handle-wallet-referrer
branch
from
November 18, 2023 10:03
a220e96
to
749c764
Compare
yeager-eren
reviewed
Nov 18, 2023
yeager-eren
reviewed
Nov 18, 2023
yeager-eren
reviewed
Nov 18, 2023
yeager-eren
reviewed
Nov 18, 2023
Ikari-Shinji-re
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A new feature has been added to the widget so that we can connect to the wallet by adding it as a autoConnect to the URL.
How did you test this change?
You can test this feature by running the widget and adding a autoConnect to the URL, the wallet should request a connection.
For example: http://localhost:3002/?autoConnect=braavos
Checklist: