Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor get legacy providers #1008

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

RyukTheCoder
Copy link
Collaborator

Summary

In some places we used separateLegacyAndHubProviders without any config to access only legacy providers which was unsafe and produced some issues after removing the experimentalWallet config. It is fixed by defining a seperate function for accessing legacy providers.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

Copy link
Collaborator

@yeager-eren yeager-eren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yeager-eren yeager-eren merged commit 8c4571e into next Jan 27, 2025
5 checks passed
@yeager-eren yeager-eren deleted the chore/refactor-get-legacy-providers branch January 27, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants