Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve issue with connecting to solana namespace #1005

Conversation

RyukTheCoder
Copy link
Collaborator

Summary

Resolved an issue in the Phantom wallet related to connecting to the Solana namespace. Previously, after disconnecting the wallet and attempting to reconnect to both Solana and EVM namespaces, errors occurred with the Solana instance. This problem was fixed by modifying the connection process to the Solana namespace, ensuring that account requests are not sent if the public key is already available.

How did you test this change?

Connected to Solana namespace, then disconnected and then connected to both namespaces. Observed that both namespaces get connected without any error.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

Copy link
Collaborator

@yeager-eren yeager-eren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. but make sure it will work in all the wallets that use this function, frontier, ledget, ...

@RyukTheCoder RyukTheCoder force-pushed the fix/rf-2203-resolve-issue-with-connecting-to-solana-namespace branch from bf81847 to d134f0d Compare January 27, 2025 14:55
@yeager-eren yeager-eren merged commit 1bde858 into next Jan 29, 2025
5 checks passed
@yeager-eren yeager-eren deleted the fix/rf-2203-resolve-issue-with-connecting-to-solana-namespace branch January 29, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants