Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set namespace field when creating relationships for helm releases #487

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Set namespace field when creating relationships for helm releases #487

wants to merge 1 commit into from

Conversation

cienijr
Copy link

@cienijr cienijr commented Nov 22, 2024

Fixes #486

@cienijr cienijr requested a review from a team as a code owner November 22, 2024 18:55
@cienijr cienijr changed the base branch from main to master November 22, 2024 19:00
@crobby crobby self-requested a review December 4, 2024 20:43
crobby
crobby previously requested changes Dec 4, 2024
View reviewed changes
Copy link

@crobby crobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cienijr I believe this should be against the main branch rather than master. That is a change we made fairly recently. Thanks

@cienijr cienijr changed the base branch from master to main December 4, 2024 23:21
@cienijr
Copy link
Author

cienijr commented Dec 4, 2024

@crobby thanks for the help. I initially opened it against the main branch, but changed it after seeing a few other PRs in this repo. I reverted it back.

@crobby crobby self-requested a review December 5, 2024 18:00
@crobby crobby dismissed their stale review December 5, 2024 20:26

change made

@prachidamle prachidamle requested a review from gehrkefc December 6, 2024 17:53
gehrkefc
gehrkefc approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@gehrkefc gehrkefc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crobby
crobby approved these changes Dec 17, 2024
View reviewed changes
Copy link

@crobby crobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable to me

@cienijr
Copy link
Author

cienijr commented Jan 31, 2025

Hello @crobby @gehrkefc 😄

Thank you both for reviewing and approving my PR. I'm not at all familiar with the Rancher development process and just wanted to check if there's anything else I should be doing to help land these changes. Please let me know if I can assist further 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gehrkefc gehrkefc gehrkefc approved these changes

@crobby crobby crobby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resources listing for Helm charts breaks if the chart refers to another namespace
3 participants
@cienijr @crobby @gehrkefc