Fix git reset command #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbron
reviewed
Jan 30, 2023
| @@ -309,7 +309,7 @@ func (g *Git) fetchAndReset(rev string) error { | |||
| } | |||
There was a problem hiding this comment.
Change is fine, confused on branching though. If v1.0.2 was tagged off of branch release-v1.0, then what is master branch ? Maybe a head ? We could use more docs :)
There was a problem hiding this comment.
Matt has this issue for branching up #250
macedogm
approved these changes
Jan 30, 2023
cbron
approved these changes
Jan 31, 2023
|
@cbron Can you merge this for me or add me as a maintainer? |
brandond
pushed a commit
to brandond/wrangler
that referenced
this pull request
Feb 7, 2023
Co-authored-by: Kevin Joiner <[email protected]>
brandond
pushed a commit
that referenced
this pull request
Feb 7, 2023
Co-authored-by: Kevin Joiner <[email protected]>
MbolotSuse
pushed a commit
to cmurphy/wrangler
that referenced
this pull request
Oct 9, 2023
Co-authored-by: Kevin Joiner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting git reset fix from release branches to master
#261