Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Release downstream components in release workflow #7596

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

rafaelbreno
Copy link
Contributor

Proposed Changes

Add an automatic release trigger for RKE2's downstream components:

Types of Changes

New feature:

  • A new step will be appended to release.yml workflow

Verification

Testing

Linked Issues

#7592

User-Facing Change


Further Comments

@rafaelbreno rafaelbreno requested a review from a team as a code owner January 14, 2025 22:23
@brooksn
Copy link
Contributor

brooksn commented Jan 15, 2025

Could you explain the failures in Dispatch and what this changes, and remove the Dispatch step and dispatch script?

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.00%. Comparing base (4d836d6) to head (d68161f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7596   +/-   ##
=======================================
  Coverage   23.00%   23.00%           
=======================================
  Files          34       34           
  Lines        3500     3500           
=======================================
  Hits          805      805           
  Misses       2647     2647           
  Partials       48       48           
Flag Coverage Δ
inttests 8.74% <ø> (ø)
unittests 16.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafaelbreno
Copy link
Contributor Author

@brooksn removed dispatch, also it was using PAT_TOKEN instead of GitHub Apps to authorize the components releases something that EIO is moving away from.

@rafaelbreno rafaelbreno merged commit 4501650 into rancher:master Jan 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants