[main] Prevent the cluster status from becoming active prematurely #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 4, 2025
yiannistri
reviewed
Mar 4, 2025
yiannistri
reviewed
Mar 5, 2025
Comment on lines
+869
to
+873
| // If status is not updating, then enqueue the update (to re-enter the onChange handler) | ||
| if config.Status.Phase != aksConfigUpdatingPhase { | ||
| return h.enqueueUpdate(config) | ||
| } | ||
|
|
There was a problem hiding this comment.
Should this block be inside the if !resourceGroupExists block a few lines up? Apologies if my previous review comment was confusing. In my opinion, we should enqueue an update right before we begin making any changes, does that make sense?
There was a problem hiding this comment.
@yiannistri We enqueue the update whenever we update the cluster. However, during the first update, the cluster does not always go into the Updating state automatically. That’s why we originally added this check—to ensure the update is re-queued when necessary.
If we move this check inside the if block, we might miss forcing the status to Updating in cases where the condition is not met. Let me know if you have any concerns!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
While updating multiple fields, changes were being applied one by one. During this process, the system periodically polls the cluster for status updates. However, the cluster status was prematurely transitioning to active instead of updating. This led to:
To address this, we now ensure that while making updates, the cluster status is enqueued as updating. This keeps the cluster continuously checking for upstream changes and prevents unintended timeouts.
Which issue(s) this PR fixes
Issue #667
Checklist: