Error handling for OG #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create a ogApi axiosInstance
- To manage 404 errors
- set the authorisation headers
- create handleOG_APIError to handle unknown errors
- create the retryOG_APIErrors to hanlde retries
- refactor all of the files in api directory to use ogApi
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #561 +/- ##
===========================================
- Coverage 97.86% 97.64% -0.22%
===========================================
Files 94 97 +3
Lines 12531 12463 -68
Branches 2025 2043 +18
===========================================
- Hits 12263 12170 -93
- Misses 266 291 +25
Partials 2 2 ☔ View full report in Codecov by Sentry. |
joshuadkitenge
force-pushed
the
DSEGOG-359-error-handling
branch
from
1c543c8 to
cb3474d
Compare
- minor styling changes to make dialogs mutation dialogs similar
joshuadkitenge
force-pushed
the
DSEGOG-359-error-handling
branch
3 times, most recently
from
a84961f to
d33f462
Compare
joshuadkitenge
force-pushed
the
DSEGOG-359-error-handling
branch
4 times, most recently
from
d8234f5 to
0f1bd34
Compare
- This test was failing due to the "PREFERRED_COLOUR_MAP_PREFERENCE_NAME"
being imported from the MSW handlers. This meant that the imports
in the settingsMenuItems had been called before the test started running.
Vitest doesn't allow you to mock an import if it is called before the
test file as it is already cached.
- The solution was to move the "PREFERRED_COLOUR_MAP_PREFERENCE_NAME"
variable to the app.types.tsx
joshuadkitenge
force-pushed
the
DSEGOG-359-error-handling
branch
from
0f1bd34 to
47d7788
Compare
joshuadkitenge
requested review from
louise-davies
and removed request for
louise-davies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reasoning
Implement the same method as IMS.
multiple queries or mutations are called
Retries are set to 3 attempts and it doesn't retry for 403 request as that is handle in the interceptors
Global error handler function set in the App.tsx handles any other errors
Reduces the amount code as the authorization header and api url are now set in the axios instance
Works well with the auto-refresh functionality currently implemented, as the automatic refresh is set to 1 minute.
Testing instructions
Agile board tracking
closes DSEGOG-359