Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dsegog 369 migrate to python 3.11 #147

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Dsegog 369 migrate to python 3.11 #147

wants to merge 19 commits into from

Conversation

moonraker595
Copy link
Contributor

@moonraker595 moonraker595 commented Nov 27, 2024 •
edited
Loading

The dev server currently uses Rocky 8 with the API running Python 3.8.

Migrating the dev server to Rocky 9 means updating to Python 3.9 as it doesn’t come with 3.8.

We might as well migrate the code base and associated setup to Python 3.11 to save doing it later.

This PR makes the necessary code changes to get the API running, and tested on 3.11.

The main issue has been getting the tests to run given a newer version of matplotlib, which includes some aliases. These have been excluded from the test as they are the same as the existing ones.

@codecov Codecov
Copy link

codecov bot commented Nov 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.67%. Comparing base (8ba1a40) to head (d465310).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff            @@
##             main     #147    +/-   ##
========================================
  Coverage   95.67%   95.67%            
========================================
  Files          73       73            
  Lines        3765     3766     +1     
  Branches      387      659   +272     
========================================
+ Hits         3602     3603     +1     
  Misses        113      113            
  Partials       50       50

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kevinphippsstfc
kevinphippsstfc requested changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@kevinphippsstfc kevinphippsstfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just doing a search for 3.8 across the repo I found that there is a reference to 3.8, 3.9, 3.10 in the docs/github_actions.md file so that paragraph could do with updating as we do not have that complication any more.

README.md Outdated
```

[Poetry](https://python-poetry.org/) is used to manage the dependencies of this API. To install Poetry, follow [the instructions](https://python-poetry.org/docs/master/#installing-with-the-official-installer) from their documentation.
[Poetry](https://python-poetry.org/) is used to manage the dependencies of this API. To install Poetry, follow [the instructions](https://python-poetry.org/docs/) from their documentation.

To install the project's dependencies, execute `poetry install`. The dependencies and the code in this repo are compatible with Python >=3.8, <3.12.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably this line needs updating so that it says 3.11 as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that, these changes have been made

kevinphippsstfc
kevinphippsstfc requested changes Jan 16, 2025
View reviewed changes
.github/workflows/ci.yml Outdated
runs-on: ${{ matrix.os }}

name: Python ${{ matrix.python-version }} Tests
runs-on: ubuntu-22.04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Louise commented, ubuntu 24.04 is available so lets try moving forward to that whilst we are updating this.

@patrick-austin patrick-austin mentioned this pull request Jan 27, 2025
Closed
patrick-austin
patrick-austin reviewed Jan 27, 2025
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@moonraker595
Copy link
Contributor Author

moonraker595 commented Jan 28, 2025 via email

@patrick-austin patrick-austin mentioned this pull request Jan 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrick-austin patrick-austin patrick-austin left review comments

@kevinphippsstfc kevinphippsstfc kevinphippsstfc requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moonraker595 @kevinphippsstfc @patrick-austin