Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add externalSize option when attaching to help auto disposing #342

Merged
merged 3 commits into from
Feb 22, 2025

Conversation

rainyl
Copy link
Owner

@rainyl rainyl commented Feb 21, 2025

fix: #341

Only supports primitive struct types like Rect and Mat, measuring the occupied bytes of other opaque types like Net is hard.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 98.59155% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.26%. Comparing base (d7617e8) to head (c55e3e9).

Files with missing lines Patch % Lines
packages/dartcv/lib/src/core/cv_vec.dart 95.00% 2 Missing ⚠️
packages/dartcv/lib/src/core/vec.dart 98.43% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
+ Coverage   93.15%   93.26%   +0.11%     
==========================================
  Files          50       50              
  Lines       10225    10266      +41     
==========================================
+ Hits         9525     9575      +50     
+ Misses        700      691       -9     
Flag Coverage Δ
unittests 93.26% <98.59%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rainyl rainyl merged commit 61b6e5d into main Feb 22, 2025
1 check passed
@rainyl rainyl deleted the externalsize branch February 22, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use externalSize of NativeFinalizer.attach to help dart VM GC scheduling heuristics
2 participants