Use latest Deno 2 version #1243
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
|
This pull request was closed for lack of activity. Feel free to reopen later. |
|
This is not stale. How can I reopen it? |
|
Sorry about that! we'll be looking at this after we are back from winter break! |
coffee-cup
reviewed
Jan 6, 2025
| @@ -46,6 +49,8 @@ pub struct BuildPlan { | |||
|
|
|||
| pub phases: Option<Phases>, | |||
|
|
|||
| pub pinned_archive: Option<String>, | |||
There was a problem hiding this comment.
This is not necessary as phases already support setting the Nix archive to a specific version, https://github.com/railwayapp/nixpacks/blob/7653b2f1a8b7c4532adb51d1c8f7f20cbd26386c/src/nixpacks/plan/phase.rs/#L207.
See this as an example
| @@ -13,6 +13,9 @@ pub const NIXPKGS_ARCHIVE: &str = "5148520bfab61f99fd25fb9ff7bfbb50dad3c9db"; | |||
| // Version of the Nix archive that uses OpenSSL 1.1 | |||
| pub const NIXPACKS_ARCHIVE_LEGACY_OPENSSL: &str = "a0b7e70db7a55088d3de0cc370a59f9fbcc906c3"; | |||
|
|
|||
| // Version of the Nix archive with the latest Deno | |||
| pub const NIXPACKS_ARCHIVE_LATEST_DENO: &str = "734af41a2b6a21fb9bf70d9f170563b6932364bb"; | |||
There was a problem hiding this comment.
This should be moved to the deno provider file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds support to
BuildPlan::pinfor pinning the build plan to any custom archive.