Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: node 23, more recent patch versions' #1223

Merged
merged 7 commits into from
Nov 21, 2024

Conversation

iloveitaly
Copy link
Contributor

I needed more recent node patch versions. Updated nix sha and added support for node 23.

@coffee-cup coffee-cup added the release/minor Author minor release label Nov 15, 2024
@coffee-cup
Copy link
Contributor

I seem to be getting a prisma unknown binary error with this change when running it locally

image

I don't see this error with the current version of Nixpacks. I'm guessing something to do with updating the node version? But they are still pulling node v18. I'm unsure atm and can do a bit more digging next week.

@iloveitaly
Copy link
Contributor Author

I bet this has to do with the postgres-dev change that I handled in the py provider PR. Without -dev the pg_config utility is not included and that causes issues with many DB libs. Can try to look into this next week.

@iloveitaly
Copy link
Contributor Author

I got this working. There were some really old versions of Prisma and Node that were causing problems with more recent SSL libraries.

Copy link
Contributor

@coffee-cup coffee-cup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring out the ssl issues!

@coffee-cup coffee-cup merged commit fd35d3c into railwayapp:main Nov 21, 2024
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/minor Author minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants