-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(search)!: Migrate to new Search UI powered by Meilisearch #240
Conversation
This PR is being deployed to Railway 🚅 📚 railway docs: ◻️ REMOVED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! I think there should be a follow up PR that fixes the keyboard navigation since that was pretty confusing when I first tried it out.
There also isn't a clear separation between the result items, but that is maybe a Jitachi question?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing else to add except from JR's comments. I have two nits, but mostly they are stylistic concerns that can be waived away if you don't feel that they are important.
This replaces the existing tag-based search with site-wide full-text search, powered by Meilisearch Cloud.
useDebouncedSearch
hook.Live demo
railway-docs-docs-pr-240.up.railway.app
Related PRs
Screens
Future Improvements
Rollout
production
:NEXT_PUBLIC_MEILISEARCH_HOST
NEXT_PUBLIC_MEILISEARCH_READ_API_KEY
NEXT_PUBLIC_MEILISEARCH_INDEX_NAME