Changes to Ruby Language section in Intro to Rails Tutorial #635
Conversation
|
@javierjulio @maxjacobson please take a look! |
|
These changes look good so far. I’m not on my Mac though but I’ll take a look again once I am. One suggestion is we should use squiggly heredoc <<~ instead as that way you can format how you like in the file but when rendered the content is right on the left edge. |
|
@javierjulio I'm not totally following your suggestion re: formatting. If it's quick, when you take a look on your mac, could you push a commit with the change you had in mind? Thanks for looking at it!!! |
|
Sure, no problem. Sorry, I’m arriving at JFK ato pick up my mother. I’ll follow up tomorrow. Thanks! |
|
I think Javier is recommending using this Ruby 2.3 feature: https://infinum.co/the-capsized-eight/multiline-strings-ruby-2-3-0-the-squiggly-heredoc I don't think it's necessary here, because the helper method already uses Line 245 in 2a5c52f This PR looks great to me -- these tweaks have all helped us out in New York, and getting them merged upstream will make it easier for us to deprecate our fork. |
There was a problem hiding this comment.
@CZagrobelny I spent more time now going through this and it looks good. I really like the hash changes which are all very descriptive. 👍🏻 Thanks!
| RUBY | ||
|
|
||
| message "And **chain** methods together:" | ||
| message "And you can call multiple methods in a row:" |
There was a problem hiding this comment.
Not a big deal but I think its helpful to have some mention of "chaining" here well assuming there isn't already on this page because "method chaining" is such a common term. I guess its obvious but figure its helpful to mention something like "also referred to as method chaining"?
There was a problem hiding this comment.
Yah, I thought about this a bit. For me, it's a level of detail that for beginners, in particular, will likely be forgotten since there is so much information coming at them, which is why I decided to keep this change from the Boston docs.
|
@rachelfenn would love to get a review on this when you have a chance! Please let me know if you have any questions! Thank you! |
This PR changes the 'Ruby Language' section of the 'Intro to Rails' tutorial. These changes came out of the NYC Chapter iterating on the Intro to Rails curriculum over the course of a year. These changes have been working great in our workshops and we would love to get them merged upstream.
Adds a 'hash' section.
Reason for Change: We found hashes to be a critical underlying concept for understanding Rails code where a hash is passed in as an argument and understanding the format of Active Record objects.
Additional explanation around the concept of 'chaining' methods.
Reason for Change: We found that this was an area of confusion for students.
Replaces wrap up question with an optional problem to solve in small groups.
Reason for Change: We found students learned the most when challenged to work together with a partner to solve a problem.
Spacing changes to enhance readability for developers editing these docs, no impact when rendered.