Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create /metrics with MAC #177

Merged
merged 1 commit into from
Aug 30, 2018
Merged

Create /metrics with MAC #177

merged 1 commit into from
Aug 30, 2018

Conversation

markulrich
Copy link
Member

No description provided.

@markulrich
Copy link
Member Author

image

Copy link
Member

@rahulgi rahulgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I think it would be more useful as a graph over time instead of just active users in the last month.

*
* Returns MAC, our "monthly active creators" metric which
* means the number of verified users who have created a
* public transaction within the last 30 days.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think we're standardized on the word operation.

<section style={{ margin: "20px" }}>
<h2>MAC (Monthly Active Creators)</h2>
<h3>
How many verified members have created at least one transaction in the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit on word operation over transaction

@markulrich
Copy link
Member Author

Thanks for feedback, created #178 for myself to track!

@markulrich markulrich merged commit e5ef62b into master Aug 30, 2018
@markulrich markulrich deleted the metrics branch August 30, 2018 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants