Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicit video refs: shared operations, models, route shapes #134

Open
wants to merge 8 commits into
base: osdiab/feature/explicit-video-refs
Choose a base branch
from

Conversation

osdiab
Copy link
Member

@osdiab osdiab commented Oct 30, 2018

Redo of #128 for simplicity of handing backwards compatibility.

Updates to shared library to support explicit video urls. Supports endpoints being either current version ones, or legacy ones.

Doesn't merge into master, merges into a explicit-video-refs branch; so feel free to review/approve and merge now.

@osdiab osdiab requested a review from rahulgi October 30, 2018 07:31
@osdiab osdiab self-assigned this Oct 30, 2018
@osdiab osdiab requested a review from tinaroh October 30, 2018 07:31
Copy link
Member

@tinaroh tinaroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we're doing legacy route, lgtm

@osdiab osdiab force-pushed the osdiab/feature/explicit-video-refs-shared-models branch from 0e5fc0a to ad48b25 Compare November 2, 2018 05:26
@osdiab osdiab force-pushed the osdiab/feature/explicit-video-refs-shared-models branch from f1e2109 to 782072f Compare November 5, 2018 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants