Update deps 2025-02 #1381
Update deps 2025-02 #1381
Conversation
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 150 files out of 257 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the WalkthroughThis pull request introduces a new dependency update call in the update script and upgrades multiple dependency versions across various package.json and Cargo.toml files. It refactors several Rust modules by replacing deprecated random generator methods with new API calls, streamlines OAuth client instantiation with method chaining, simplifies control flows, and removes obsolete endpoints from API controllers. Additionally, the Rust toolchain version is updated, and minor improvements in error handling and macro implementations are introduced. Changes
Sequence Diagram(s)sequenceDiagram
participant C as Client
participant B as ServerConfigBuilder
participant OAuth as OAuthClient (BasicClient)
C->>B: Call build()
B->>OAuth: BasicClient::new(client_id)
OAuth-->>B: Returns partially initialized client
B->>OAuth: set_client_secret(secret)
B->>OAuth: set_auth_uri(auth_url)
B->>OAuth: set_token_uri(token_url)
OAuth-->>B: Fully configured OAuthClient
B-->>C: Return OAuthClient wrapped in Data
Possibly related PRs
Suggested labels
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
dependencies
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
services/headless-lms/server/src/domain/authorization.rs (1)
954-990: Enhanced custom OAuth HTTP client.The function properly sets custom headers and re-wraps responses into OAuth2-friendly data structures. One minor suggestion: you might capture and log the original parse errors and request-execution errors more verbosely to facilitate debugging.
services/headless-lms/server/src/programs/doc_file_generator/mod.rs (1)
307-307: Consider documenting the reason for using#[allow(non_local_definitions)].The attribute suggests that the function contains definitions that could be moved to a more appropriate scope. Please add a comment explaining why this attribute is necessary.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (13)
package-lock.jsonis excluded by!**/package-lock.jsonservices/cms/package-lock.jsonis excluded by!**/package-lock.jsonservices/course-material/package-lock.jsonis excluded by!**/package-lock.jsonservices/example-exercise/package-lock.jsonis excluded by!**/package-lock.jsonservices/headless-lms/Cargo.lockis excluded by!**/*.lockservices/main-frontend/package-lock.jsonis excluded by!**/package-lock.jsonservices/quizzes/package-lock.jsonis excluded by!**/package-lock.jsonservices/tmc/package-lock.jsonis excluded by!**/package-lock.jsonshared-module/package-lock.jsonis excluded by!**/package-lock.jsonshared-module/packages/common/package-lock.jsonis excluded by!**/package-lock.jsonshared-module/packages/create-exercise-service/package-lock.jsonis excluded by!**/package-lock.jsonstorybook/package-lock.jsonis excluded by!**/package-lock.jsonsystem-tests/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (38)
bin/update-dependencies-part-1(1 hunks)package.json(1 hunks)rust-toolchain.toml(1 hunks)services/cms/package.json(3 hunks)services/course-material/package.json(2 hunks)services/example-exercise/package.json(2 hunks)services/headless-lms/certificates/Cargo.toml(1 hunks)services/headless-lms/chatbot/Cargo.toml(2 hunks)services/headless-lms/doc-macro/Cargo.toml(1 hunks)services/headless-lms/langs-api/Cargo.toml(1 hunks)services/headless-lms/models/Cargo.toml(2 hunks)services/headless-lms/models/src/exercise_slide_submissions.rs(1 hunks)services/headless-lms/models/src/library/peer_or_self_reviewing.rs(2 hunks)services/headless-lms/models/src/library/user_exercise_state_updater/state_deriver.rs(1 hunks)services/headless-lms/models/src/offered_answers_to_peer_review_temporary.rs(1 hunks)services/headless-lms/models/src/test_helper.rs(3 hunks)services/headless-lms/server/Cargo.toml(5 hunks)services/headless-lms/server/src/config.rs(1 hunks)services/headless-lms/server/src/controllers/cms/pages.rs(0 hunks)services/headless-lms/server/src/controllers/course_material/courses.rs(0 hunks)services/headless-lms/server/src/controllers/helpers/file_uploading.rs(2 hunks)services/headless-lms/server/src/controllers/main_frontend/courses.rs(1 hunks)services/headless-lms/server/src/controllers/main_frontend/pages.rs(0 hunks)services/headless-lms/server/src/domain/authorization.rs(4 hunks)services/headless-lms/server/src/domain/csv_export/mod.rs(1 hunks)services/headless-lms/server/src/domain/models_requests.rs(1 hunks)services/headless-lms/server/src/lib.rs(1 hunks)services/headless-lms/server/src/programs/doc_file_generator/mod.rs(1 hunks)services/headless-lms/server/src/test_helper.rs(3 hunks)services/headless-lms/utils/Cargo.toml(2 hunks)services/headless-lms/utils/src/file_store/mod.rs(2 hunks)services/headless-lms/utils/src/strings.rs(2 hunks)services/main-frontend/package.json(3 hunks)services/quizzes/package.json(2 hunks)services/tmc/package.json(2 hunks)shared-module/package.json(1 hunks)shared-module/packages/common/package.json(1 hunks)system-tests/package.json(1 hunks)
💤 Files with no reviewable changes (3)
- services/headless-lms/server/src/controllers/cms/pages.rs
- services/headless-lms/server/src/controllers/main_frontend/pages.rs
- services/headless-lms/server/src/controllers/course_material/courses.rs
✅ Files skipped from review due to trivial changes (6)
- services/headless-lms/server/src/domain/csv_export/mod.rs
- rust-toolchain.toml
- services/headless-lms/chatbot/Cargo.toml
- services/headless-lms/certificates/Cargo.toml
- services/headless-lms/server/src/controllers/main_frontend/courses.rs
- shared-module/package.json
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: build-and-deploy
- GitHub Check: headless_lms
🔇 Additional comments (113)
services/headless-lms/server/src/domain/authorization.rs (4)
16-16: Import for custom HTTP client error looks good.The introduction of
HttpClientErroraligns with the updated error handling strategy.
21-21: Use of Lazy for static initialization is acceptable.Using
Lazyensures thread-safe, on-demand initialization for the static client.
35-42: Static HTTP client initialization is clear and consistent.Defining a static
OAUTH_HTTP_CLIENToffers a single, reusable instance of the client. Just confirm you’re okay with panicking on failure with.expect(...)rather than gracefully handling the error at runtime.
739-739: Correct usage of the async request function.Passing the custom HTTP client function is properly updated to match the new signature.
services/headless-lms/utils/src/strings.rs (3)
2-2: Confirm the usage ofrng()from the rand crate.Ensure that
rng()is stable and properly version-pinned in Cargo.toml.
11-11: Random string generator logic is consistent.Using
rng().sample_iter(Alphanumeric)is functionally equivalent to previous thread-based RNG calls for generating random alphanumeric strings.
19-19: Filtering characters is correct and user friendly.Excluding visually similar characters should reduce confusion. Implementation looks solid.
bin/update-dependencies-part-1 (1)
58-58: Extending dependency updates to a new shared-module directory.Adding a call to
update_node_depsforshared-module/packages/commonis consistent with the existing pattern in this script.services/headless-lms/server/src/lib.rs (1)
31-31: LGTM! Enhanced type safety for OAuth client.The updated type definition with explicit endpoint states (
EndpointSet,EndpointNotSet) improves type safety by making the OAuth client configuration requirements more explicit at compile time.Also applies to: 37-43
services/headless-lms/models/src/offered_answers_to_peer_review_temporary.rs (1)
14-14: Verify random number generation behavior.The change from
thread_rng().gen_range()torng().random_range()might affect the cleanup trigger probability. Ensure that the new API maintains the same distribution characteristics.Run this script to check the distribution of random numbers:
services/headless-lms/utils/src/file_store/mod.rs (1)
15-15: Verify random string generation behavior.The change from
distributions::DistStringtodistr::SampleStringand the updated string generation API might affect the randomness characteristics of generated filenames.Run this script to verify the random string generation:
Also applies to: 77-77
services/headless-lms/server/src/config.rs (1)
76-80: LGTM! Improved OAuth client configuration.The changes enhance the code in two ways:
- Method chaining improves readability by clearly separating each configuration step
- Explicit type annotation adds clarity and type safety
services/headless-lms/models/src/test_helper.rs (1)
138-138: LGTM! Verify rand crate version compatibility.The updates to use
rand::rng()andrand::distr::Alphanumericalign with the latest rand crate API.Run this script to verify the rand crate version:
Also applies to: 148-148, 158-158
✅ Verification successful
Rand Crate Version Compatibility Verified
- The
randdependency is set to"0.9.0"in all relevantCargo.tomlfiles.- The usage of
::rand::rng()and::rand::distr::Alphanumericis compatible with therandcrate version 0.9.0.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check rand crate version in Cargo.toml files # Expect: Version should be compatible with the new API (>= 0.9.0) rg -l 'rand = "' | xargs catLength of output: 11837
services/headless-lms/server/src/test_helper.rs (1)
151-151: LGTM! Changes are consistent.The random number generation updates match the changes in the models test helper, maintaining consistency across the codebase.
Also applies to: 161-161, 171-171
services/headless-lms/server/src/domain/models_requests.rs (1)
99-99: LGTM! Lifetime specification simplified.The change to use an anonymous lifetime (
'_) instead of an explicit lifetime parameter simplifies the code without affecting functionality.services/headless-lms/server/src/controllers/helpers/file_uploading.rs (2)
18-19: LGTM! Import changes align with the updated rand crate module structure.The imports have been updated to use the new
distrmodule instead ofdistributions, which is the correct module path for the latest rand crate.
277-277: Verify the random string generation change.The change from
thread_rng()torng()could affect the randomness source. While both methods are valid, let's verify that this change is consistent with other similar changes in the codebase.✅ Verification successful
Random string generator usage is now consistent across the codebase.
The change fromthread_rng()torng()is uniformly applied, as verified by the absence ofthread_rng()and the prevalent usage ofrng()in multiple files.
- The file
services/headless-lms/server/src/controllers/helpers/file_uploading.rsnow usesrand::rng()correctly.- Similar patterns using
rng()were found across test helpers and other modules.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for any remaining uses of thread_rng() that might need updating # and verify the consistency of random number generation across the codebase echo "Checking for remaining thread_rng() usage..." rg "thread_rng\(\)" echo "Checking for new rng() usage pattern..." rg "rng\(\)"Length of output: 1976
services/headless-lms/models/src/exercise_slide_submissions.rs (1)
294-294: LGTM! Random number generation update is consistent.The change from
thread_rng()torng()aligns with similar updates across the codebase.services/headless-lms/models/src/library/peer_or_self_reviewing.rs (2)
5-5: LGTM! Import update aligns with the new random number generation approach.The import has been updated to use
rnginstead ofthread_rng, maintaining consistency with other files.
581-581: LGTM! Random number generation update is consistent.The change from
thread_rng()torng()follows the same pattern seen in other files.services/headless-lms/models/src/library/user_exercise_state_updater/state_deriver.rs (1)
167-170: LGTM! Code flow has been simplified while maintaining functionality.The control flow has been streamlined by removing the explicit return statement and using
unwrap_or_elsefor cleaner fallback logic.services/headless-lms/doc-macro/Cargo.toml (1)
12-13: Updated "syn" Dependency Version
The version for thesyndependency has been bumped to"2.0.98"with the existing feature set intact. This update is consistent with the other dependency updates across the project.services/headless-lms/langs-api/Cargo.toml (3)
12-13: Updated "oauth2" Dependency Version
Theoauth2dependency is now set to"5.0.0". Please ensure that any breaking changes or migration notes from the upstream library have been reviewed and accommodated in the codebase.
16-17: Updated "serde_json" Dependency Version
Theserde_jsondependency has been updated to"1.0.138", aligning it with the version upgrades elsewhere in the project.
20-21: Updated "uuid" Dependency Version
The version for theuuiddependency is now"1.12.1"with theserdefeature enabled. This change helps maintain consistency across the services.services/example-exercise/package.json (6)
23-23: Updated "@tanstack/react-query" Version
The dependency@tanstack/react-queryhas been updated to"^5.66.0", which is in line with the overall dependency standardization across services.
29-29: Updated "i18next" Version
Thei18nextpackage version update to"^24.2.2"ensures consistency with dependency updates in other modules.
33-35: Updated "next", "react", and "react-dom" Versions
The updates to"next": "^15.1.6","react": "^19.0.0", and"react-dom": "^19.0.0"support the latest features and performance improvements. Please verify that UI components and server-side functionality remain fully compatible.
49-52: Updated Type Definitions in DevDependencies
The upgrades for@types/lodash,@types/node,@types/react, and@types/react-domimprove TypeScript compatibility with the updated libraries.
55-56: Updated "postcss-styled-syntax" and "stylelint" Versions in DevDependencies
Minor version bumps for these tools ensure better integration and consistency with styling and linting processes across the project.
61-64: Updated Overrides for React Packages
Switching override values forreact,react-dom,@types/react, and@types/react-domto"$react"promotes flexible version resolution.services/tmc/package.json (6)
24-25: Updated Dependencies: "@tanstack/react-query" and "@types/ws"
The dependency@tanstack/react-queryis now"^5.66.0", and@types/wshas been updated to"^8.5.14". Make sure that any API or type changes introduced are accommodated accordingly.
33-33: Updated "i18next" Dependency Version
The upgrade to"^24.2.2"fori18nextmaintains consistency with other services and should streamline internationalization workflows.
37-39: Updated "next", "react", and "react-dom" Versions
Upgrading"next"to"^15.1.6"and both"react"and"react-dom"to"^19.0.0"enables the use of the latest features and optimizations. Ensure that the front-end renders and behaves as expected after these updates.
54-56: Updated DevDependency Type Definitions
The updates for@types/lodash,@types/react, and@types/react-domimprove type safety in development and should work harmoniously with the updated libraries.
60-60: Updated "postcss-styled-syntax" Version in DevDependencies
The upgrade to"^0.7.1"ensures that style preprocessing remains consistent with other parts of the project.
64-67: Updated Overrides for React Dependencies
Setting the overrides forreact,react-dom,@types/react, and@types/react-domto"$react"provides a more flexible dependency resolution mechanism.package.json (5)
26-29: Updated ESLint and TypeScript Plugin Dependencies
The updates for@tanstack/eslint-plugin-query,@types/node,@typescript-eslint/eslint-plugin, and@typescript-eslint/parserto their newer versions bring enhanced linting and type-checking improvements.
31-33: Updated ESLint Core and Configurations
Upgradingeslint,eslint-config-next, andeslint-config-prettierto"^9.19.0","^15.1.6", and"^10.0.1"respectively strengthens code quality enforcement and compatibility with the latest Next.js features.
35-41: Updated ESLint Plugins for i18next, Import, JSX-A11y, Playwright, and React
These updates enhance the linting rules for internationalization, module imports, accessibility, and React best practices, ensuring more robust code quality across the project.
43-45: Updated Linting and PostCSS Dependencies
The version bumps forlint-staged,postcss, andpostcss-styled-syntaxsupport improved development workflows and maintain consistency in style processing.
48-48: Updated "stylelint" Dependency
Upgradingstylelintto"^16.14.1"brings enhancements in CSS linting, aligning it with the updates in other similar services.system-tests/package.json (2)
32-37: Updated DevDependency Versions for Playwright and Node Types.
The version bumps for@playwright/browser-chromium,@playwright/test,@types/node, andplaywrightalign with the overall dependency upgrade objective. Please ensure that these new versions do not introduce breaking changes in your system tests.
44-44: Tar-fs Version Update in Dependencies.
The upgrade oftar-fsto^3.0.8is consistent with coordinated dependency updates and should be verified within integration tests.services/quizzes/package.json (15)
24-24: Updated @next/bundle-analyzer Version.
The change to^15.1.6is in line with similar updates across the codebase for improved tool consistency.
26-26: Updated @tanstack/react-query Version.
The version bump to^5.66.0ensures consistency with updates in other services.
33-33: Updated dompurify Version.
The update to^3.2.4meets the goals of uniform dependency versions across modules.
36-36: Updated i18next Version.
Changing the version to^24.2.2standardizes the dependency upgrade across services.
38-38: Updated katex Version.
The upgrade to^0.16.21reflects the coordinated effort to keep dependencies current.
41-41: Updated Next.js Version.
Changing to^15.1.6is consistent with updates elsewhere. Verify that all Next.js–related logic is compatible with this version.
42-42: Updated PostCSS Version.
The bump to^8.5.1aligns with the broader dependency update strategy.
43-43: Updated React Version.
Upgrading React to^19.0.0is a substantial change; please verify the compatibility of all React components and the testing suite.
44-44: Updated React-DOM Version.
The upgrade to^19.0.0should be coordinated with the React update to ensure consistency in rendering behavior.
58-58: Updated @types/lodash in DevDependencies.
The upgrade to^4.17.15is consistent with other services and should improve type checking accuracy.
60-60: Updated @types/react in DevDependencies.
The change to^19.0.0supports the upgrade of React and its ecosystem.
61-61: Updated @types/react-dom in DevDependencies.
This update to^19.0.0mirrors the React upgrade and is critical for maintaining type integrity.
66-66: Updated postcss-styled-syntax in DevDependencies.
The new version^0.7.1meets our standardization goals across projects.
67-67: Updated stylelint Version in DevDependencies.
Changing to^16.14.1improves linting consistency across our services.
74-77: Unified Overrides for React Packages.
By settingreact,react-dom,@types/react, and@types/react-domto$react, the override promotes consistent version management.services/main-frontend/package.json (16)
13-13: Updated @citation-js/plugin-bibtex Version.
The version upgrade to^0.7.18aligns with similar dependency updates in related services.
25-25: Updated @next/bundle-analyzer Version.
Maintaining consistency with other services, the update to^15.1.6is well justified.
27-27: Updated @tanstack/react-query Version.
The bump to^5.66.0is part of the coordinated effort to standardize dependency versions.
31-31: Updated citation-js Version.
Upgrading to^0.7.18ensures the package stays current and in sync with other module updates.
39-39: Updated i18next Version.
The new version^24.2.2is consistent with other updates across our services.
43-43: Updated Next.js Version.
Changing to^15.1.6reflects an overall upgrade strategy; please verify all Next.js–dependent functionality.
44-44: Added/Updated Papaparse Dependency.
The inclusion ofpapaparseat^5.5.2should be validated for compatibility across consumers of CSV parsing functionality.
45-45: Updated React Version.
The significant upgrade to^19.0.0must be thoroughly tested within the front-end environment for potential breaking changes.
46-46: Updated React-DOM Version.
Ensure that the upgrade to^19.0.0is comprehensively compatible with the React version and UI rendering tests.
59-59: Updated @types/diff in DevDependencies.
The minor update to^7.0.1improves type safety without major impact.
60-60: Updated @types/lodash in DevDependencies.
This change to^4.17.15is consistent with our overall type definition strategy.
61-61: Updated @types/node in DevDependencies.
Bumping to^22.13.0ensures improved type definitions in line with the latest Node versions.
63-63: Updated @types/react in DevDependencies.
The update to^19.0.0is necessary to match the React upgrade and maintain coherent type definitions.
64-64: Updated @types/react-dom in DevDependencies.
This version bump to^19.0.0supports the React ecosystem update.
68-68: Updated stylelint in DevDependencies.
The new version^16.14.1further aligns our linting tools across projects.
73-76: Unified Overrides for React Packages.
Switching to the$reactvariable forreact,react-dom,@types/react, and@types/react-domenforces consistency and easier version management.services/course-material/package.json (17)
24-24: Updated @tanstack/react-query Version.
The version update to^5.66.0ensures consistency with the global dependency upgrade initiative.
27-27: Updated citation-js Version.
Bumping to^0.7.18aligns with similar changes across related services.
31-31: Updated dompurify Version.
The update to^3.2.4is consistent with our coordinated update strategy.
35-35: Updated i18next Version.
Changing to^24.2.2reflects the overall synchronization of dependency versions across services.
37-37: Updated katex Version.
Upgrading to^0.16.21is part of the standardized updates and should be verified with the rendering components.
40-40: Updated Next.js Version.
The bump to^15.1.6is consistent with the dependency management strategy across projects.
41-41: Updated React Version.
The upgrade to^19.0.0necessitates careful testing with course content components to ensure full compatibility.
42-42: Updated React-DOM Version.
This change to^19.0.0should be paired with comprehensive UI testing to catch any possible regressions.
52-52: Updated tsparticles Version.
The update to^3.8.1meets the planned dependency version changes and should be verified with particle rendering features.
60-60: Updated @types/diff in DevDependencies.
The upgrade to^7.0.1is straightforward and aligns with other services’ updates.
64-64: Updated @types/lodash in DevDependencies.
The new version^4.17.15is consistent with the unified upgrade strategy.
65-65: Updated @types/node in DevDependencies.
Bumping to^22.13.0maintains consistency among our Node type definitions.
66-66: Updated @types/react in DevDependencies.
The update to^19.0.0supports the React upgrade in dependencies.
67-67: Updated @types/react-dom in DevDependencies.
This change to^19.0.0provides necessary support for the updated React-DOM library.
72-72: Updated postcss-styled-syntax in DevDependencies.
Upgrading to^0.7.1is standard across our services and helps maintain consistency in styles linting.
73-73: Updated stylelint in DevDependencies.
The upgrade to^16.14.1matches the coordinated updates seen in similar projects.
79-82: Unified Overrides for React Packages.
Using the$reactvariable forreact,react-dom,@types/react, and@types/react-domis an excellent step for consistent versioning.services/headless-lms/models/Cargo.toml (3)
24-24: Updated uuid Crate Version.
The change to version"1.12.1"with the specified features ensures alignment with similar updates in other headless-lms packages.
30-30: Updated serde_json Crate Version.
Bumping to"1.0.138"is consistent with our dependency upgrade plans and should enhance serialization performance.
56-56: Updated rand Crate Version.
The update to"0.9.0"reflects upstream improvements and keeps the randomness functionality up to date across the headless-lms project.shared-module/packages/common/package.json (3)
12-62: Dependency Version Updates in "dependencies" Section
The dependencies have been updated to newer versions for a variety of packages (e.g.,@citation-js/plugin-bibtex,@emotion/*, various Fontsource and FontAwesome packages, etc.). One point to note is the usage of React version"^19.0.0"here, which differs from some other parts of the project. Please verify that this discrepancy is intentional and that it won’t lead to compatibility issues across the workspace.
65-84: DevDependencies Version Updates
The devDependencies have been uniformly upgraded (including updates for@testing-library/react, several@types/*packages,msw,postcss-styled-syntax,stylelint, andtypescript). Ensure that these updates do not break existing tests or type checking and that any custom configurations in your build/test pipeline remain compatible.
87-90: Overrides Section Updates
The overrides now forcereact,react-dom, and their type packages to the workspace variable$react. Confirm that this strategy correctly centralizes the React version across all packages to prevent version mismatches.services/cms/package.json (2)
15-62: Dependency Version Updates in CMS
This file shows significant dependency updates including:
- Upgrading
@tanstack/react-queryto"^5.66.0".- Updating multiple
@wordpress/*packages (e.g.,@wordpress/base-styles,@wordpress/block-editor, etc.) to newer versions.- Bumping
katexto"^0.16.21"andnextto"^15.1.6".One notable point is that React is specified as
"^18.3.1"here, in contrast to"^19.0.0"in the common package. Please verify that this difference is intentional and that the override mechanism (if any) will reconcile these versions across the codebase.
64-88: DevDependencies and Overrides Consistency
The devDependencies have been upgraded (e.g.,@types/node,@wordpress/scripts,json-schema-to-typescript, etc.) and the overrides section now enforces React-related packages using$react. Ensure that these settings are consistent with the overall project configuration and that automated builds and tests continue to pass after these updates.services/headless-lms/utils/Cargo.toml (5)
22-23: Update UUID Dependency
Theuuiddependency has been updated to version"1.12.1"with features[\"serde\", \"v4\", \"v5\"]. This change aligns with updates in other Cargo.toml files, so please confirm that UUID generation and serialization behaviors are as expected.
28-29: Update serde_json Dependency
serde_jsonis now at version"1.0.138". Verify that any JSON serialization or deserialization logic in the project works correctly with this version and that there are no breaking changes in the API.
34-35: Update async-trait
Theasync-traitdependency has been updated to"0.1.86". Please double-check that all async trait implementations still compile and function properly with this upgrade.
38-39: Update rand Dependency
Theranddependency is upgraded from"0.8.5"to"0.9.0". Since rand can introduce API changes, ensure that any logic relying on random number generation has been tested against the new version.
69-70: Update ipnet Dependency
Theipnetdependency has been bumped to version"2.11.0". Confirm that all code utilizing IP network address parsing or validation continues to work as intended.services/headless-lms/server/Cargo.toml (7)
39-39: Update listenfd Dependency Version
Thelistenfddependency has been updated to"1.0.2". This is a minor update that should improve compatibility with socket activation mechanisms, so this change looks appropriate.
45-45: Update UUID Dependency in Server
Theuuiddependency here is updated to"1.12.1"with the appropriate features. Confirm that this update is harmonized with the changes in related packages.
50-51: Update serde_json Dependency
serde_jsonhas been bumped to"1.0.138". Please verify that all JSON handling in the server component continues to function correctly with this version change.
109-109: Update tempfile Dependency
Thetempfiledependency is now"3.16.0". Please check that any temporary file operations are unaffected and that no API changes have been introduced that require code updates.
115-115: Update rand Dependency
randis updated to"0.9.0". Similar to other occurrences, ensure that use cases involving randomness conform to the new API and that no unexpected behavior occurs.
127-127: Update async-trait Dependency in Server
The async-trait dependency has been updated to"0.1.86"here as well. Make sure that asynchronous trait implementations throughout the server continue to compile and run as expected.
139-139: DevDependency: Update rand
The dev-dependency forrandhas also been updated to"0.9.0", ensuring consistency between development and production builds.services/headless-lms/server/src/programs/doc_file_generator/mod.rs (1)
308-323: LGTM! The documentation generation forStudyRegistryCompletionis well-structured.The function provides a comprehensive example of the
StudyRegistryCompletionstruct with realistic values, which is valuable for API documentation.A few observations:
- The example includes both required and optional fields (
tierandcompletion_registration_attempt_dateareNone).- The
user_idfield uses theExampletrait implementation.- The date values and UUIDs are fixed, making the documentation reproducible.
Let's verify that all fields in the example match the actual struct definition:
✅ Verification successful
Field Consistency Verification for
StudyRegistryCompletionis confirmed.
All fields in the example (including types and order) match the struct definition inservices/headless-lms/models/src/course_module_completions.rs:
completion_date: Uses a properDateTime<Utc>value.completion_language: Provided as a validString.completion_registration_attempt_date: Correctly shown asNone, matchingOption<DateTime<Utc>>.Stringtype.grade: Instantiated properly viaStudyRegistryGrade::new.id: Parsed to aUuidas expected.user_id: Passed as a field (assumed to be a validUuidper the context).tier: Appropriately set toNone, conforming toOption<i32>.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that all fields in the example match the struct definition. # Test: Search for the StudyRegistryCompletion struct definition ast-grep --pattern $'struct StudyRegistryCompletion { $$$ }'Length of output: 63
Script:
#!/bin/bash # Use ripgrep to locate the definition of StudyRegistryCompletion with context of its fields. rg "struct StudyRegistryCompletion" -n .Length of output: 147
Script:
#!/bin/bash # Extract the full definition of StudyRegistryCompletion from the models file. sed -n '/pub struct StudyRegistryCompletion {/,/}/p' ./services/headless-lms/models/src/course_module_completions.rsLength of output: 1690
| @@ -64,7 +64,7 @@ reqwest = { version = "0.12.12", features = ["brotli", "gzip", "json", "http2", | |||
| # Sessions for Actix web | |||
| actix-session = { version = "0.7.2", features = ["cookie-session"] } | |||
| # An extensible, strongly-typed implementation of OAuth2 | |||
| oauth2 = "4.4.2" | |||
| oauth2 = "5.0.0" | |||
There was a problem hiding this comment.
Major Upgrade for oauth2 Dependency
The oauth2 dependency has been upgraded from "4.4.2" to "5.0.0". This major version change likely introduces breaking changes. It is critical to review and test all OAuth client instantiation and related flows thoroughly.
Summary by CodeRabbit