Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing translations #1380

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Add missing translations #1380

merged 1 commit into from
Feb 3, 2025

Conversation

nygrenh
Copy link
Member

@nygrenh nygrenh commented Jan 30, 2025

Summary by CodeRabbit

  • Localization
    • Added Arabic and Ukrainian language support for course material and frontend localization
    • Introduced new keys for reporting functionality, including buttons for reporting content, flagging reasons (AI-generated, harmful, spam), and review thresholds

Copy link
Contributor

coderabbitai bot commented Jan 30, 2025

Walkthrough

This pull request introduces localization updates for Arabic and Ukrainian language files, specifically in the course materials and main frontend JSON files. The changes focus on adding new keys related to content reporting, flagging, and user feedback mechanisms. These additions include buttons for reporting, reasons for flagging content (such as AI-generated, harmful, or spam), and labels for managing reported content across different language localizations.

Changes

File Change Summary
shared-module/packages/common/src/locales/ar/course-material.json Added localization keys for reporting buttons, flagging reasons, and report dialog title
shared-module/packages/common/src/locales/ar/main-frontend.json Added labels for reporting, flagged content, and review thresholds
shared-module/packages/common/src/locales/uk/course-material.json Added Ukrainian translations for reporting buttons, flagging reasons, and report dialog elements
shared-module/packages/common/src/locales/uk/main-frontend.json Added Ukrainian labels for reporting, flagged content, and review processes

Possibly related PRs

Suggested labels

shared-module, course-material

Poem

🐰 Localization Hop! 🌍

Across languages, words take flight,
Reporting buttons shining bright,
Arabic and Ukrainian sing,
Of feedback's powerful wing,
A translation rabbit's delight! 🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
shared-module/packages/common/src/locales/uk/main-frontend.json (1)

384-384: Consider using a more specific translation for "label-report".

While "Звіт" is technically correct, consider using "Поскаржитися" or "Повідомити про проблему" to better indicate the action of reporting content rather than viewing a report.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1d0be07 and fa79125.

📒 Files selected for processing (4)
  • shared-module/packages/common/src/locales/ar/course-material.json (5 hunks)
  • shared-module/packages/common/src/locales/ar/main-frontend.json (3 hunks)
  • shared-module/packages/common/src/locales/uk/course-material.json (5 hunks)
  • shared-module/packages/common/src/locales/uk/main-frontend.json (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: headless_lms
  • GitHub Check: build
  • GitHub Check: build-and-deploy
🔇 Additional comments (5)
shared-module/packages/common/src/locales/ar/course-material.json (1)

26-26: LGTM! Arabic translations for the reporting functionality are well-implemented.

The translations are semantically accurate, culturally appropriate, and follow proper Arabic language conventions. The terminology used is consistent and clear.

Also applies to: 94-96, 150-150, 178-178, 203-203

shared-module/packages/common/src/locales/uk/course-material.json (1)

27-27: LGTM! Ukrainian translations for the reporting functionality are well-implemented.

The translations are semantically accurate, culturally appropriate, and follow proper Ukrainian language conventions. The terminology used is consistent and clear.

Also applies to: 95-97, 153-153, 183-183, 208-208

shared-module/packages/common/src/locales/ar/main-frontend.json (2)

347-347: LGTM! Arabic translations for the reporting functionality labels are well-implemented.

The translations are semantically accurate, culturally appropriate, and follow proper Arabic language conventions. The terminology used is consistent and clear.

Also applies to: 379-380, 383-383, 397-397


Line range hint 1-1: Verify translation key consistency across language files.

Let's ensure all reporting-related keys are present in both Arabic and Ukrainian translations.

✅ Verification successful

All translation keys are consistent across language files

All reporting-related translation keys are properly maintained in both Arabic and Ukrainian translations, ensuring a complete and consistent user experience across languages.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if all reporting-related keys exist in both Arabic and Ukrainian translations

# Define the keys to check
KEYS=(
  "button-text-report"
  "flagging-reason-ai-generated"
  "flagging-reason-harmful-content"
  "flagging-reason-spam"
  "optional-description"
  "select-reason"
  "title-report-dialog"
)

# Check course-material.json files
echo "Checking course-material.json files..."
for key in "${KEYS[@]}"; do
  echo "Checking key: $key"
  echo "Arabic:"
  rg "\"$key\":" "shared-module/packages/common/src/locales/ar/course-material.json"
  echo "Ukrainian:"
  rg "\"$key\":" "shared-module/packages/common/src/locales/uk/course-material.json"
  echo
done

# Check main-frontend.json for label keys
echo "Checking main-frontend.json for label keys..."
LABEL_KEYS=(
  "label-flagged-by"
  "label-reason"
  "label-received-reports"
  "label-report"
  "label-threshold-to-move-flagged-answer-to-manual-review"
)

for key in "${LABEL_KEYS[@]}"; do
  echo "Checking key: $key"
  echo "Arabic:"
  rg "\"$key\":" "shared-module/packages/common/src/locales/ar/main-frontend.json"
  echo
done

Length of output: 5251


Script:

#!/bin/bash
# Check main-frontend.json label keys in Ukrainian
LABEL_KEYS=(
  "label-flagged-by"
  "label-reason"
  "label-received-reports"
  "label-report"
  "label-threshold-to-move-flagged-answer-to-manual-review"
)

echo "Checking Ukrainian main-frontend.json for label keys..."
for key in "${LABEL_KEYS[@]}"; do
  echo "Checking key: $key"
  rg "\"$key\":" "shared-module/packages/common/src/locales/uk/main-frontend.json"
  echo
done

Length of output: 1650

shared-module/packages/common/src/locales/uk/main-frontend.json (1)

348-348: LGTM! The translations are accurate and consistent.

The translations for flagging-related labels are well-chosen and maintain consistency with the UI context.

Also applies to: 380-381, 398-398

@nygrenh nygrenh merged commit 468d3e2 into master Feb 3, 2025
18 checks passed
@nygrenh nygrenh deleted the update-translations branch February 3, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant