-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing translations #1380
Add missing translations #1380
Conversation
WalkthroughThis pull request introduces localization updates for Arabic and Ukrainian language files, specifically in the course materials and main frontend JSON files. The changes focus on adding new keys related to content reporting, flagging, and user feedback mechanisms. These additions include buttons for reporting, reasons for flagging content (such as AI-generated, harmful, or spam), and labels for managing reported content across different language localizations. Changes
Possibly related PRs
Suggested labels
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
shared-module/packages/common/src/locales/uk/main-frontend.json (1)
384-384
: Consider using a more specific translation for "label-report".While "Звіт" is technically correct, consider using "Поскаржитися" or "Повідомити про проблему" to better indicate the action of reporting content rather than viewing a report.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
shared-module/packages/common/src/locales/ar/course-material.json
(5 hunks)shared-module/packages/common/src/locales/ar/main-frontend.json
(3 hunks)shared-module/packages/common/src/locales/uk/course-material.json
(5 hunks)shared-module/packages/common/src/locales/uk/main-frontend.json
(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: headless_lms
- GitHub Check: build
- GitHub Check: build-and-deploy
🔇 Additional comments (5)
shared-module/packages/common/src/locales/ar/course-material.json (1)
26-26
: LGTM! Arabic translations for the reporting functionality are well-implemented.The translations are semantically accurate, culturally appropriate, and follow proper Arabic language conventions. The terminology used is consistent and clear.
Also applies to: 94-96, 150-150, 178-178, 203-203
shared-module/packages/common/src/locales/uk/course-material.json (1)
27-27
: LGTM! Ukrainian translations for the reporting functionality are well-implemented.The translations are semantically accurate, culturally appropriate, and follow proper Ukrainian language conventions. The terminology used is consistent and clear.
Also applies to: 95-97, 153-153, 183-183, 208-208
shared-module/packages/common/src/locales/ar/main-frontend.json (2)
347-347
: LGTM! Arabic translations for the reporting functionality labels are well-implemented.The translations are semantically accurate, culturally appropriate, and follow proper Arabic language conventions. The terminology used is consistent and clear.
Also applies to: 379-380, 383-383, 397-397
Line range hint
1-1
: Verify translation key consistency across language files.Let's ensure all reporting-related keys are present in both Arabic and Ukrainian translations.
✅ Verification successful
All translation keys are consistent across language files ✅
All reporting-related translation keys are properly maintained in both Arabic and Ukrainian translations, ensuring a complete and consistent user experience across languages.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if all reporting-related keys exist in both Arabic and Ukrainian translations # Define the keys to check KEYS=( "button-text-report" "flagging-reason-ai-generated" "flagging-reason-harmful-content" "flagging-reason-spam" "optional-description" "select-reason" "title-report-dialog" ) # Check course-material.json files echo "Checking course-material.json files..." for key in "${KEYS[@]}"; do echo "Checking key: $key" echo "Arabic:" rg "\"$key\":" "shared-module/packages/common/src/locales/ar/course-material.json" echo "Ukrainian:" rg "\"$key\":" "shared-module/packages/common/src/locales/uk/course-material.json" echo done # Check main-frontend.json for label keys echo "Checking main-frontend.json for label keys..." LABEL_KEYS=( "label-flagged-by" "label-reason" "label-received-reports" "label-report" "label-threshold-to-move-flagged-answer-to-manual-review" ) for key in "${LABEL_KEYS[@]}"; do echo "Checking key: $key" echo "Arabic:" rg "\"$key\":" "shared-module/packages/common/src/locales/ar/main-frontend.json" echo doneLength of output: 5251
Script:
#!/bin/bash # Check main-frontend.json label keys in Ukrainian LABEL_KEYS=( "label-flagged-by" "label-reason" "label-received-reports" "label-report" "label-threshold-to-move-flagged-answer-to-manual-review" ) echo "Checking Ukrainian main-frontend.json for label keys..." for key in "${LABEL_KEYS[@]}"; do echo "Checking key: $key" rg "\"$key\":" "shared-module/packages/common/src/locales/uk/main-frontend.json" echo doneLength of output: 1650
shared-module/packages/common/src/locales/uk/main-frontend.json (1)
348-348
: LGTM! The translations are accurate and consistent.The translations for flagging-related labels are well-chosen and maintain consistency with the UI context.
Also applies to: 380-381, 398-398
Summary by CodeRabbit