Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make marking completions as registered not to crash if a completion has been deleted before the marking has succeeded #1376

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Make marking completions as registered not to crash if a completion has been deleted before the marking has succeeded #1376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...fe0938212dba397aafd2581193b93c05dcb2.json → ...7321c55f43c5c1d3aadc646876b41b1beb01.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion services/headless-lms/models/src/course_module_completions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ WHERE id = $1
Ok(res)
}

/// Also returns soft deleted completions so that we can make sure the process does not crash if a completion is deleted before we get it back from the study registry.
pub async fn get_by_ids(
conn: &mut PgConnection,
ids: &[Uuid],
Expand All @@ -168,7 +169,6 @@ pub async fn get_by_ids(
SELECT *
FROM course_module_completions
WHERE id = ANY($1)
AND deleted_at IS NULL
",
ids,
)
Expand Down
Loading