Make marking completions as registered not to crash if a completion h…

…as been deleted before the marking has succeeded
rage · Jan 30, 2025 · ac44676 · ac44676
1 parent 660bdf4
commit ac44676
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...fe0938212dba397aafd2581193b93c05dcb2.json → ...7321c55f43c5c1d3aadc646876b41b1beb01.json b/...fe0938212dba397aafd2581193b93c05dcb2.json → ...7321c55f43c5c1d3aadc646876b41b1beb01.json
diff --git a/services/headless-lms/models/src/course_module_completions.rs b/services/headless-lms/models/src/course_module_completions.rs
@@ -158,6 +158,7 @@ WHERE id = $1
     Ok(res)
 }
 
+/// Also returns soft deleted completions so that we can make sure the process does not crash if a completion is deleted before we get it back from the study registry.
 pub async fn get_by_ids(
     conn: &mut PgConnection,
     ids: &[Uuid],
@@ -168,7 +169,6 @@ pub async fn get_by_ids(
 SELECT *
 FROM course_module_completions
 WHERE id = ANY($1)
-  AND deleted_at IS NULL
         ",
         ids,
     )