Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also use ubuntu-latest for the FreeBSD build #240

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

melroy89
Copy link
Contributor

@melroy89 melroy89 commented Dec 6, 2024

Let's also use the ubuntu-latest run tag for the FreeBSD which is still Ubuntu 22.04, but most likely soon Ubuntu 24.04: https://github.com/actions/runner-images

@Neustradamus
Copy link
Member

@stappersg
Copy link
Member

stappersg commented Dec 6, 2024 via email

@RICCIARDI-Adrien
Copy link
Contributor

Hi !
The last release of the FreeBSD action (https://github.com/vmactions/freebsd-vm/tree/v1.1.5) is indeed running on Ubuntu 24.04.
I would suggest to also update uses: vmactions/[email protected] to uses: vmactions/freebsd-vm@v1 so we always use the last action version, hoping it won't break.

@melroy89
Copy link
Contributor Author

melroy89 commented Dec 6, 2024

Hi ! The last release of the FreeBSD action (https://github.com/vmactions/freebsd-vm/tree/v1.1.5) is indeed running on Ubuntu 24.04. I would suggest to also update uses: vmactions/[email protected] to uses: vmactions/freebsd-vm@v1 so we always use the last action version, hoping it won't break.

Agreed. Updated as well!

Assuming they do not introduce breaking changes in the same major release (which they shouldn't).

@RICCIARDI-Adrien
Copy link
Contributor

Looks good to me !

@melroy89
Copy link
Contributor Author

melroy89 commented Dec 6, 2024

It seems you & I have no approval right (meaning you will need at least write access to this org or to this repo).

Copy link
Member

@stappersg stappersg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@stappersg
Copy link
Member

This approve merge request is a lead by example reference to #237

@stappersg stappersg merged commit 5eeabd3 into radvd-project:master Dec 7, 2024
42 checks passed
@stappersg stappersg mentioned this pull request Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants