Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hardcoded list of resource types from cli. #8286

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

nithyatsu
Copy link
Contributor

Description

Since we now register resource provider manifests at startup and are in process of enabling UDT end to end, we should not use static resource type lists.

This PR removes static resource type lists in cli code.

Type of change

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • [X ] Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • [X ] Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • [ X] Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • [X ] Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • [X ] Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • [ X] Not applicable

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 34.90566% with 69 lines in your changes missing coverage. Please review.

Project coverage is 59.75%. Comparing base (bb7f774) to head (4ec7b77).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cli/clients/gomock_reflect_508337358/prog.go 0.00% 42 Missing ⚠️
pkg/cli/clients/management.go 58.82% 14 Missing and 7 partials ⚠️
pkg/cli/cmd/resource/list/list.go 40.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8286      +/-   ##
==========================================
- Coverage   59.82%   59.75%   -0.08%     
==========================================
  Files         590      591       +1     
  Lines       39513    39574      +61     
==========================================
+ Hits        23639    23646       +7     
- Misses      14114    14164      +50     
- Partials     1760     1764       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant