Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add purge job for bicep artifacts #8281

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add purge job for bicep artifacts #8281

wants to merge 5 commits into from

Conversation

sk593
Copy link
Contributor

@sk593 sk593 commented Jan 23, 2025

Description

This adds a purge job for test bicep artifacts. It will delete any manifests that are older than 90 days. This only applies to the test schemas uploaded as part of PRs, not any major release versions of Radius or AWS bicep types.

A successful test run can be found here: https://github.com/radius-project/radius/actions/runs/12939411131

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
  • If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

@sk593 sk593 requested a deployment to functional-tests January 23, 2025 17:14 — with GitHub Actions Waiting
@sk593 sk593 mentioned this pull request Jan 23, 2025
6 tasks
Copy link

github-actions bot commented Jan 23, 2025

Unit Tests

3 552 tests  ±0   3 548 ✅ ±0   5m 30s ⏱️ +13s
  292 suites ±0       4 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 347c4a1. ± Comparison against base commit 7797bb0.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.83%. Comparing base (7797bb0) to head (347c4a1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8281      +/-   ##
==========================================
+ Coverage   59.81%   59.83%   +0.01%     
==========================================
  Files         590      590              
  Lines       39513    39513              
==========================================
+ Hits        23636    23642       +6     
+ Misses      14116    14112       -4     
+ Partials     1761     1759       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: sk593 <[email protected]>
Signed-off-by: sk593 <[email protected]>
Signed-off-by: sk593 <[email protected]>
@sk593 sk593 requested a deployment to functional-tests January 23, 2025 23:03 — with GitHub Actions Waiting
@sk593 sk593 marked this pull request as ready for review January 23, 2025 23:03
@sk593 sk593 requested review from a team as code owners January 23, 2025 23:03
- name: Login to Azure
uses: azure/login@v2
with:
client-id: ${{ secrets.BICEPTYPES_CLIENT_ID }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need separate accounts for different operations? The other purge action uses AZURE_SP_TESTS_APPID. Wouldn't having one shared be better for actions that can be grouped together?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants