Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set cache option on setup-go action in workflows #8280

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

brooke-hamilton
Copy link
Member

@brooke-hamilton brooke-hamilton commented Jan 23, 2025

Description

This PR sets the cache: true option on the setup-go actions in the workflows. Previously we used a common caching technique to cache the go install and modules folders, but this feature is now built into the setup-go action. This change was tested with PR #8276. Following that, this PR updates the remaining workflows to use the new caching feature.

The default value for the cache option is true on the setup-go@v5 action. This PR explicitly sets the value to true on the action where it is not specified so that the option will be obvious, even though it will not change the behavior of the action for cases when the option was not set.

  • build.yaml: Explicitly set cache option to true, which is the same as the default value.
  • functional-test-cloud.yaml: Changed the cache option from false to true and removed the original caching actions.
  • lint.yaml: Explicitly set cache option to true, which is the same as the default value.
  • long-running-azure.yaml: Explicitly set cache option to true, which is the same as the default value.
  • publish-docs.yaml: Explicitly set cache option to true, which is the same as the default value.

NOTE: This PR is created from a branch in this repo instead of a fork from an external repo to allow us to run the cloud test workflows.

Type of change

  • This pull request adds or changes features of Radius and has an approved issue (issue link required).

Related to issue: #8274
Related to PR #8276

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
  • If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

Signed-off-by: Brooke Hamilton <[email protected]>
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 23, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 127b30b
Unique ID funca0795240f2
Image tag pr-funca0795240f2
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funca0795240f2
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funca0795240f2
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funca0795240f2
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funca0795240f2
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funca0795240f2
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

Copy link

github-actions bot commented Jan 23, 2025

Unit Tests

3 562 tests  ±0   3 558 ✅ ±0   5m 21s ⏱️ +2s
  292 suites ±0       4 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 8c2a076. ± Comparison against base commit da85dab.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.83%. Comparing base (da85dab) to head (8c2a076).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8280   +/-   ##
=======================================
  Coverage   59.82%   59.83%           
=======================================
  Files         590      590           
  Lines       39520    39520           
=======================================
+ Hits        23644    23646    +2     
+ Misses      14120    14119    -1     
+ Partials     1756     1755    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Brooke Hamilton <[email protected]>
@brooke-hamilton brooke-hamilton marked this pull request as ready for review January 23, 2025 16:08
@brooke-hamilton brooke-hamilton requested review from a team as code owners January 23, 2025 16:08
@radius-functional-tests

This comment has been minimized.

@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 23, 2025

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
❌ corerp-cloud functional test failed. Please check the logs for more details
⌛ Starting corerp-cloud functional tests...
✅ corerp-cloud functional tests succeeded

Copy link
Contributor

@superbeeny superbeeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for finding this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants