-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set cache option on setup-go action in workflows #8280
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Brooke Hamilton <[email protected]>
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8280 +/- ##
=======================================
Coverage 59.82% 59.83%
=======================================
Files 590 590
Lines 39520 39520
=======================================
+ Hits 23644 23646 +2
+ Misses 14120 14119 -1
+ Partials 1756 1755 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Brooke Hamilton <[email protected]>
This comment has been minimized.
This comment has been minimized.
⌛ Building Radius and pushing container images for functional tests... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for finding this
Description
This PR sets the
cache: true
option on thesetup-go
actions in the workflows. Previously we used a common caching technique to cache the go install and modules folders, but this feature is now built into thesetup-go
action. This change was tested with PR #8276. Following that, this PR updates the remaining workflows to use the new caching feature.The default value for the
cache
option istrue
on thesetup-go@v5
action. This PR explicitly sets the value totrue
on the action where it is not specified so that the option will be obvious, even though it will not change the behavior of the action for cases when the option was not set.build.yaml
: Explicitly set cache option to true, which is the same as the default value.functional-test-cloud.yaml
: Changed the cache option from false to true and removed the original caching actions.lint.yaml
: Explicitly set cache option to true, which is the same as the default value.long-running-azure.yaml
: Explicitly set cache option to true, which is the same as the default value.publish-docs.yaml
: Explicitly set cache option to true, which is the same as the default value.Type of change
Related to issue: #8274
Related to PR #8276
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: