Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing hack folder for bicep types generator #8278

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sk593
Copy link
Contributor

@sk593 sk593 commented Jan 22, 2025

Description

This removes the hack folder for the bicep types generator. The hack folder was needed when we had a fork of Bicep but doesn't need to be there anymore.

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
  • If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

Copy link

Unit Tests

3 562 tests  ±0   3 558 ✅ ±0   5m 15s ⏱️ -3s
  292 suites ±0       4 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit e273f06. ± Comparison against base commit 16660a5.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.82%. Comparing base (16660a5) to head (e273f06).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8278      +/-   ##
==========================================
- Coverage   59.84%   59.82%   -0.02%     
==========================================
  Files         590      590              
  Lines       39520    39520              
==========================================
- Hits        23649    23643       -6     
- Misses      14117    14121       +4     
- Partials     1754     1756       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant