Resource type create - fixes #8248

nithyatsu · 2025-01-15T16:54:45Z

Description

Fixes below issues in resource-type create

APIversion for the created resource-type was blank.
Display of the resource-type created at the end of the command was incorrect
Added UTs that would have caught these issues.
sample manifest updated to have just one resource-type

Type of change

This pull request fixes a bug in Radius and has an approved issue (issue link required).
This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional)

Fixes: #issue_number

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

[ NA ] An overview of proposed schema changes is included in a linked GitHub issue.
[ NA ] A design document PR is created in the design-notes repository, if new APIs are being introduced.
[ NA ] If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
[ NA ] A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
[ NA ] A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
[ NA ] A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

codecov · 2025-01-15T20:24:31Z

Codecov Report

Attention: Patch coverage is 65.38462% with 18 lines in your changes missing coverage. Please review.

Project coverage is 59.81%. Comparing base (d56c866) to head (1667248).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/cli/cmd/resourcetype/create/create.go	52.63%	6 Missing and 3 partials ⚠️
pkg/cli/manifest/registermanifest.go	50.00%	4 Missing and 2 partials ⚠️
pkg/cli/cmd/resourcetype/common/resourcetype.go	80.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8248      +/-   ##
==========================================
+ Coverage   59.73%   59.81%   +0.08%     
==========================================
  Files         590      590              
  Lines       39487    39520      +33     
==========================================
+ Hits        23588    23640      +52     
+ Misses      14152    14123      -29     
- Partials     1747     1757      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/cli/cmd/resourcetype/common/resourcetype.go

pkg/cli/cmd/resourcetype/create/create.go

lakshmimsft · 2025-01-16T01:22:41Z

pkg/cli/manifest/registermanifest.go

+		if err != nil {
+			return err
+		}
+


nit: extra line

radius-functional-tests · 2025-01-16T22:08:11Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`68597a2`
Unique ID	func14682348df
Image tag	pr-func14682348df

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func14682348df
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func14682348df
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func14682348df
controller test image location: ghcr.io/radius-project/dev/controller:pr-func14682348df
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func14682348df
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

pkg/cli/clients/errors.go

radius-functional-tests · 2025-01-17T17:22:42Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`1667248`
Unique ID	funcf44eb20529
Image tag	pr-funcf44eb20529

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcf44eb20529
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcf44eb20529
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcf44eb20529
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcf44eb20529
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcf44eb20529
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

nithyatsu requested review from a team as code owners January 15, 2025 16:54

nithyatsu temporarily deployed to publish-bicep January 15, 2025 16:55 — with GitHub Actions Inactive

nithyatsu marked this pull request as draft January 15, 2025 16:55

nithyatsu temporarily deployed to publish-bicep January 15, 2025 18:53 — with GitHub Actions Inactive

nithyatsu temporarily deployed to publish-bicep January 15, 2025 18:58 — with GitHub Actions Inactive

nithyatsu marked this pull request as ready for review January 15, 2025 18:59

nithyatsu changed the title ~~Resource type create - fix apiversion~~ Resource type create - fixes Jan 15, 2025

nithyatsu temporarily deployed to publish-bicep January 15, 2025 19:42 — with GitHub Actions Inactive

lakshmimsft reviewed Jan 15, 2025

View reviewed changes

pkg/cli/cmd/resourcetype/common/resourcetype.go Show resolved Hide resolved

lakshmimsft reviewed Jan 15, 2025

View reviewed changes

pkg/cli/cmd/resourcetype/create/create.go Show resolved Hide resolved

lakshmimsft reviewed Jan 16, 2025

View reviewed changes

pkg/cli/cmd/resourcetype/create/create.go Show resolved Hide resolved

lakshmimsft reviewed Jan 16, 2025

View reviewed changes

pkg/cli/manifest/registermanifest.go Outdated

if err != nil {

return err

}

Copy link

Contributor

lakshmimsft Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra line

nithyatsu mentioned this pull request Jan 16, 2025

GetResourceProviderSummary method references should be on UCPApplicationsManagementClient #8251

Open

nithyatsu added 7 commits January 16, 2025 13:55

wip

b8a3c74

add UT

e0f9b6c

refactoring

f83e41c

remove redundant comment

d70dc77

lint fixes

da8ac4a

wip

348431c

refactor error, add missing UT

68597a2

nithyatsu force-pushed the resource_type_create branch from 1064ab5 to 68597a2 Compare January 16, 2025 21:56

nithyatsu temporarily deployed to publish-bicep January 16, 2025 21:56 — with GitHub Actions Inactive

nithyatsu temporarily deployed to functional-tests January 16, 2025 22:07 — with GitHub Actions Inactive

fix test

99c86eb

nithyatsu temporarily deployed to publish-bicep January 16, 2025 23:03 — with GitHub Actions Inactive

lakshmimsft reviewed Jan 16, 2025

View reviewed changes

pkg/cli/clients/errors.go Outdated Show resolved Hide resolved

nit

1667248

nithyatsu temporarily deployed to publish-bicep January 17, 2025 17:20 — with GitHub Actions Inactive

nithyatsu requested a review from lakshmimsft January 17, 2025 17:21

nithyatsu temporarily deployed to functional-tests January 17, 2025 17:21 — with GitHub Actions Inactive

lakshmimsft approved these changes Jan 17, 2025

View reviewed changes

nithyatsu merged commit 846f546 into radius-project:main Jan 17, 2025
29 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resource type create - fixes #8248

Resource type create - fixes #8248

nithyatsu commented Jan 15, 2025 •

edited

Loading

codecov bot commented Jan 15, 2025 •

edited

Loading

lakshmimsft Jan 16, 2025

radius-functional-tests bot commented Jan 16, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 17, 2025 •

edited

Loading

Resource type create - fixes #8248

Resource type create - fixes #8248

Conversation

nithyatsu commented Jan 15, 2025 • edited Loading

Description

Type of change

Contributor checklist

codecov bot commented Jan 15, 2025 • edited Loading

Codecov Report

lakshmimsft Jan 16, 2025

Choose a reason for hiding this comment

radius-functional-tests bot commented Jan 16, 2025 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jan 17, 2025 • edited Loading

Radius functional test overview

Test Status

nithyatsu commented Jan 15, 2025 •

edited

Loading

codecov bot commented Jan 15, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 16, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 17, 2025 •

edited

Loading