Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: Fuzz test for resource id parser #8214

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

justinmaks
Copy link
Contributor

@justinmaks justinmaks commented Jan 9, 2025

Description

This PR adds a fuzz test to the resource ID parser. This does not close the mentioned issue due to it not being integrated to testing pipeline.

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Part of: #8105

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
  • If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

@justinmaks justinmaks requested review from a team as code owners January 9, 2025 20:23
@superbeeny
Copy link
Contributor

superbeeny commented Jan 9, 2025

Please add a description to the PR and capitalize the first word of the title

@justinmaks justinmaks changed the title add: fuzz test for resource id parser add: Fuzz test for resource id parser Jan 9, 2025
pkg/ucp/resources/id_test.go Show resolved Hide resolved
pkg/ucp/resources/id_test.go Outdated Show resolved Hide resolved
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 9, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository justinmaks/radius
Commit ref d32208f
Unique ID func0fcf1c4f92
Image tag pr-func0fcf1c4f92
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func0fcf1c4f92
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func0fcf1c4f92
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func0fcf1c4f92
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func0fcf1c4f92
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func0fcf1c4f92
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 9, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository justinmaks/radius
Commit ref 10d3da9
Unique ID funca6f1f8af33
Image tag pr-funca6f1f8af33
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funca6f1f8af33
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funca6f1f8af33
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funca6f1f8af33
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funca6f1f8af33
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funca6f1f8af33
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@rynowak rynowak merged commit a7f5a83 into radius-project:main Jan 9, 2025
28 checks passed
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.75%. Comparing base (9e74e73) to head (10d3da9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8214   +/-   ##
=======================================
  Coverage   59.75%   59.75%           
=======================================
  Files         590      590           
  Lines       39487    39487           
=======================================
  Hits        23597    23597           
  Misses      14146    14146           
  Partials     1744     1744           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants