UDT - Remove Legacy Routing #8205

lakshmimsft · 2025-01-08T16:28:22Z

Description

Remove Legacy Routing. Update tests as necessary
Add global location, address to manifests. Include them in ucp images.

Type of change

This pull request adds or changes features of Radius and has an approved issue (User-Defined Resource Types #6688 ).

Part of: #6688

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
A design document PR is created in the design-notes repository, if new APIs are being introduced.
If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

radius-functional-tests · 2025-01-08T17:55:53Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	lakshmimsft/radius-mainfork
Commit ref	`94382b0`
Unique ID	funcd3eb7cf3c1
Image tag	pr-funcd3eb7cf3c1

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcd3eb7cf3c1
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcd3eb7cf3c1
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcd3eb7cf3c1
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcd3eb7cf3c1
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcd3eb7cf3c1
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
❌ Failed to install Radius for corerp-cloud functional test. Please check the logs for more details
❌ corerp-cloud functional test failed. Please check the logs for more details
❌ ucp-cloud functional test cancelled. Please check the logs for more details

codecov · 2025-01-08T18:42:34Z

Codecov Report

Attention: Patch coverage is 86.11111% with 5 lines in your changes missing coverage. Please review.

Project coverage is 59.82%. Comparing base (fa809bf) to head (22ac115).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/cli/manifest/registermanifest.go	90.62%	1 Missing and 2 partials ⚠️
pkg/ucp/frontend/controller/resourcegroups/util.go	50.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8205      +/-   ##
==========================================
- Coverage   59.84%   59.82%   -0.02%     
==========================================
  Files         590      590              
  Lines       39520    39513       -7     
==========================================
- Hits        23649    23639      -10     
+ Misses      14118    14114       -4     
- Partials     1753     1760       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

radius-functional-tests · 2025-01-10T08:38:14Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	lakshmimsft/radius-mainfork
Commit ref	`c8c1be3`
Unique ID	func7bdea55e54
Image tag	pr-func7bdea55e54

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func7bdea55e54
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func7bdea55e54
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func7bdea55e54
controller test image location: ghcr.io/radius-project/dev/controller:pr-func7bdea55e54
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func7bdea55e54
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
❌ Failed to install Radius for corerp-cloud functional test. Please check the logs for more details
❌ corerp-cloud functional test failed. Please check the logs for more details
❌ ucp-cloud functional test cancelled. Please check the logs for more details

radius-functional-tests · 2025-01-10T22:47:18Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	lakshmimsft/radius-mainfork
Commit ref	`cf8042e`
Unique ID	func447998d1ea
Image tag	pr-func447998d1ea

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func447998d1ea
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func447998d1ea
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func447998d1ea
controller test image location: ghcr.io/radius-project/dev/controller:pr-func447998d1ea
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func447998d1ea
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
❌ corerp-cloud functional test failed. Please check the logs for more details

radius-functional-tests · 2025-01-10T23:58:32Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	lakshmimsft/radius-mainfork
Commit ref	`e7ff53c`
Unique ID	func97987471d5
Image tag	pr-func97987471d5

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func97987471d5
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func97987471d5
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func97987471d5
controller test image location: ghcr.io/radius-project/dev/controller:pr-func97987471d5
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func97987471d5
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

radius-functional-tests · 2025-01-11T02:26:30Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	lakshmimsft/radius-mainfork
Commit ref	`11b4f4f`
Unique ID	funcdb51c7693a
Image tag	pr-funcdb51c7693a

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcdb51c7693a
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcdb51c7693a
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcdb51c7693a
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcdb51c7693a
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcdb51c7693a
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

radius-functional-tests · 2025-01-13T21:39:02Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	lakshmimsft/radius-mainfork
Commit ref	`923152d`
Unique ID	func1ffb386327
Image tag	pr-func1ffb386327

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func1ffb386327
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func1ffb386327
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func1ffb386327
controller test image location: ghcr.io/radius-project/dev/controller:pr-func1ffb386327
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func1ffb386327
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

radius-functional-tests · 2025-01-17T23:41:41Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	lakshmimsft/radius-mainfork
Commit ref	`e5c5e96`
Unique ID	funce67d8e2afc
Image tag	pr-funce67d8e2afc

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funce67d8e2afc
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funce67d8e2afc
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funce67d8e2afc
controller test image location: ghcr.io/radius-project/dev/controller:pr-funce67d8e2afc
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funce67d8e2afc
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

ytimocin · 2025-01-18T04:55:33Z

.github/workflows/functional-test-noncloud.yaml

+          echo "*** Verify manifests are registered ***"
+          rm -f registermanifest_logs.txt
+          # Find the pod with container "ucp"
+          POD_NAME=$(
+            kubectl get pods -n radius-system \
+              -o jsonpath='{range .items[*]}{.metadata.name}{" "}{.spec.containers[*].name}{"\n"}{end}' \
+            | grep "ucp" \
+            | head -n1 \
+            | cut -d" " -f1
+          )
+          echo "Found ucp pod: $POD_NAME"
+
+          if [ -z "$POD_NAME" ]; then
+            echo "No pod with container 'ucp' found in namespace radius-system."
+            exit 1
+          fi


This shouldn't be the case if the rad install command above succeeds. There should be a UCP pod for sure. Otherwise, we have a problem.

.github/workflows/functional-test-noncloud.yaml

ytimocin · 2025-01-18T04:57:43Z

.github/workflows/functional-test-noncloud.yaml

+
+          # Final check to ensure success message was found
+          if ! grep -q "Successfully registered manifests" registermanifest_logs.txt; then
+            echo "Manifests not registered after 3 minutes."


Shouldn't this be checked during rad install? Can this case happen after rad install successfully finishes? As a user, when rad install shows me success output, I wouldn't expect an error afterwards.

The registering of manifests runs as a service that depends on ucp to be running (is started up) and it registers manifests. It is possible that the ucp pod is already up and the registering of manifests is underway (not all completed) when the calls are made on ln 337 prematurely. Let's discuss. I didn't see an obvious way to include this as part of rad install.
I didn't see this occur in the cloud tests but preemptively making sure registering manifests is completed before proceeding with tests.

ytimocin · 2025-01-18T05:05:55Z

pkg/cli/manifest/registermanifest.go

+		for locationName, address = range resourceProvider.Location {
+			// We support one location per resourceProvider
+			break
+		}


So, the for loop updates the locationName with the first location name from the map... We should add a note here.

test/functional-portable/ucp/noncloud/resourceprovider_test.go

radius-functional-tests · 2025-01-21T16:53:12Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	lakshmimsft/radius-mainfork
Commit ref	`c678769`
Unique ID	func11e3d0e4b9
Image tag	pr-func11e3d0e4b9

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func11e3d0e4b9
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func11e3d0e4b9
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func11e3d0e4b9
controller test image location: ghcr.io/radius-project/dev/controller:pr-func11e3d0e4b9
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func11e3d0e4b9
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

cmd/ucpd/ucp-dev.yaml

deploy/Chart/templates/ucp/configmaps.yaml

Signed-off-by: lakshmimsft <[email protected]>

radius-functional-tests · 2025-01-21T18:39:53Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	lakshmimsft/radius-mainfork
Commit ref	`22ac115`
Unique ID	funca528d6005a
Image tag	pr-funca528d6005a

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funca528d6005a
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funca528d6005a
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funca528d6005a
controller test image location: ghcr.io/radius-project/dev/controller:pr-funca528d6005a
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funca528d6005a
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

This reverts commit bb7f774.

# Description 1. Remove Legacy Routing. Update tests as necessary 2. Add global location, address to manifests. Include them in ucp images. ## Type of change - This pull request adds or changes features of Radius and has an approved issue (#6688 ). Part of: #6688 ## Contributor checklist Please verify that the PR meets the following requirements, where applicable: - [ ] An overview of proposed schema changes is included in a linked GitHub issue. - [ ] A design document PR is created in the [design-notes repository](https://github.com/radius-project/design-notes/), if new APIs are being introduced. - [ ] If applicable, design document has been reviewed and approved by Radius maintainers/approvers. - [ ] A PR for the [samples repository](https://github.com/radius-project/samples) is created, if existing samples are affected by the changes in this PR. - [ ] A PR for the [documentation repository](https://github.com/radius-project/docs) is created, if the changes in this PR affect the documentation or any user facing updates are made. - [ ] A PR for the [recipes repository](https://github.com/radius-project/recipes) is created, if existing recipes are affected by the changes in this PR. --------- Signed-off-by: lakshmimsft <[email protected]>

# Description Commit for PR #8205 is being reinstated with updates to cloud and non-cloud test workflows. The updates to the workflows are in commit 940a693. Original PR Description: 1. Remove Legacy Routing. Update tests as necessary 2. Add global location, address to manifests. Include them in ucp images. ## Type of change - This pull request adds or changes features of Radius and has an approved issue (#6688 ). Part of: #6688 ## Contributor checklist Please verify that the PR meets the following requirements, where applicable: - [ ] An overview of proposed schema changes is included in a linked GitHub issue. - [ ] A design document PR is created in the [design-notes repository](https://github.com/radius-project/design-notes/), if new APIs are being introduced. - [ ] If applicable, design document has been reviewed and approved by Radius maintainers/approvers. - [ ] A PR for the [samples repository](https://github.com/radius-project/samples) is created, if existing samples are affected by the changes in this PR. - [ ] A PR for the [documentation repository](https://github.com/radius-project/docs) is created, if the changes in this PR affect the documentation or any user facing updates are made. - [ ] A PR for the [recipes repository](https://github.com/radius-project/recipes) is created, if existing recipes are affected by the changes in this PR. --------- Signed-off-by: lakshmimsft <[email protected]>

lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from 3c22547 to 94382b0 Compare January 8, 2025 17:47

lakshmimsft temporarily deployed to publish-bicep January 8, 2025 17:48 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to functional-tests January 8, 2025 17:48 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from 94382b0 to 138974f Compare January 9, 2025 00:09

lakshmimsft temporarily deployed to publish-bicep January 9, 2025 00:09 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to publish-bicep January 10, 2025 08:36 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to functional-tests January 10, 2025 08:37 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from c8c1be3 to 07f1803 Compare January 10, 2025 22:43

lakshmimsft temporarily deployed to publish-bicep January 10, 2025 22:43 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from 07f1803 to cf8042e Compare January 10, 2025 22:45

lakshmimsft temporarily deployed to publish-bicep January 10, 2025 22:46 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to functional-tests January 10, 2025 22:46 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from cf8042e to e7ff53c Compare January 10, 2025 23:39

lakshmimsft temporarily deployed to publish-bicep January 10, 2025 23:39 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to functional-tests January 10, 2025 23:57 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from e7ff53c to 11b4f4f Compare January 11, 2025 02:24

lakshmimsft temporarily deployed to publish-bicep January 11, 2025 02:24 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to functional-tests January 11, 2025 02:25 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from 11b4f4f to 923152d Compare January 13, 2025 21:28

lakshmimsft temporarily deployed to publish-bicep January 13, 2025 21:28 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to functional-tests January 13, 2025 21:38 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from 923152d to f860504 Compare January 14, 2025 00:32

lakshmimsft temporarily deployed to publish-bicep January 14, 2025 00:33 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to publish-bicep January 17, 2025 23:16 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from 38e1740 to 3e637de Compare January 17, 2025 23:32

lakshmimsft had a problem deploying to publish-bicep January 17, 2025 23:32 — with GitHub Actions Error

lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from 3e637de to e5c5e96 Compare January 17, 2025 23:33

lakshmimsft temporarily deployed to publish-bicep January 17, 2025 23:33 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to functional-tests January 17, 2025 23:40 — with GitHub Actions Inactive

ytimocin reviewed Jan 18, 2025

View reviewed changes

lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from e5c5e96 to c678769 Compare January 21, 2025 16:39

lakshmimsft temporarily deployed to publish-bicep January 21, 2025 16:42 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to functional-tests January 21, 2025 16:44 — with GitHub Actions Inactive

nithyatsu reviewed Jan 21, 2025

View reviewed changes

cmd/ucpd/ucp-dev.yaml Show resolved Hide resolved

nithyatsu reviewed Jan 21, 2025

View reviewed changes

deploy/Chart/templates/ucp/configmaps.yaml Show resolved Hide resolved

nithyatsu approved these changes Jan 21, 2025

View reviewed changes

lakshmimsft added 3 commits January 21, 2025 10:37

remove legacy routing

2977c21

Signed-off-by: lakshmimsft <[email protected]>

enable register manifest

8a2af96

Signed-off-by: lakshmimsft <[email protected]>

waiting for registered manifests

22ac115

Signed-off-by: lakshmimsft <[email protected]>

lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from c678769 to 22ac115 Compare January 21, 2025 18:37

lakshmimsft temporarily deployed to publish-bicep January 21, 2025 18:38 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to functional-tests January 21, 2025 18:38 — with GitHub Actions Inactive

lakshmimsft merged commit bb7f774 into radius-project:main Jan 21, 2025
29 checks passed

lakshmimsft added a commit to lakshmimsft/radius-mainfork that referenced this pull request Jan 22, 2025

Revert "UDT - Remove Legacy Routing (radius-project#8205)"

d756104

This reverts commit bb7f774.

kachawla pushed a commit that referenced this pull request Jan 22, 2025

Revert "UDT - Remove Legacy Routing (#8205)" (#8270)

a665232

lakshmimsft mentioned this pull request Jan 23, 2025

Reapply UDT - Remove Legacy Routing #8275

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UDT - Remove Legacy Routing #8205

UDT - Remove Legacy Routing #8205

lakshmimsft commented Jan 8, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 8, 2025 •

edited

Loading

codecov bot commented Jan 8, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 10, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 10, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 10, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 11, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 13, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 17, 2025 •

edited

Loading

ytimocin Jan 18, 2025

ytimocin Jan 18, 2025

lakshmimsft Jan 21, 2025 •

edited

Loading

ytimocin Jan 18, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 21, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 21, 2025 •

edited

Loading

UDT - Remove Legacy Routing #8205

UDT - Remove Legacy Routing #8205

Conversation

lakshmimsft commented Jan 8, 2025 • edited Loading

Description

Type of change

Contributor checklist

radius-functional-tests bot commented Jan 8, 2025 • edited Loading

Radius functional test overview

Test Status

codecov bot commented Jan 8, 2025 • edited Loading

Codecov Report

radius-functional-tests bot commented Jan 10, 2025 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jan 10, 2025 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jan 10, 2025 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jan 11, 2025 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jan 13, 2025 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jan 17, 2025 • edited Loading

Radius functional test overview

Test Status

ytimocin Jan 18, 2025

Choose a reason for hiding this comment

ytimocin Jan 18, 2025

Choose a reason for hiding this comment

lakshmimsft Jan 21, 2025 • edited Loading

Choose a reason for hiding this comment

ytimocin Jan 18, 2025 • edited Loading

Choose a reason for hiding this comment

radius-functional-tests bot commented Jan 21, 2025 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jan 21, 2025 • edited Loading

Radius functional test overview

Test Status

lakshmimsft commented Jan 8, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 8, 2025 •

edited

Loading

codecov bot commented Jan 8, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 10, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 10, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 10, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 11, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 13, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 17, 2025 •

edited

Loading

lakshmimsft Jan 21, 2025 •

edited

Loading

ytimocin Jan 18, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 21, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 21, 2025 •

edited

Loading