Adding Postgres Helm chart to rad init #8072
Open
+118
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superbeeny
temporarily deployed
to
publish-bicep
GitHub Actions
Inactive
superbeeny
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
ytimocin
reviewed
Nov 20, 2024
rynowak
reviewed
Nov 21, 2024
rynowak
reviewed
Nov 21, 2024
rynowak
reviewed
Nov 21, 2024
rynowak
reviewed
Nov 21, 2024
rynowak
reviewed
Nov 21, 2024
rynowak
reviewed
Nov 21, 2024
rynowak
reviewed
Nov 21, 2024
rynowak
reviewed
Nov 21, 2024
rynowak
reviewed
Nov 21, 2024
superbeeny
had a problem deploying
to
publish-bicep
GitHub Actions
Error
superbeeny
temporarily deployed
to
publish-bicep
GitHub Actions
Inactive
rynowak
reviewed
Nov 21, 2024
rynowak
reviewed
Nov 21, 2024
superbeeny
force-pushed
the
features/superbeeny/postgreschart
branch
from
9251b92 to
3377dc7
Compare
superbeeny
temporarily deployed
to
publish-bicep
GitHub Actions
Inactive
|
Functional test failure looks unrelated. Rerunning. If it fails again, it might be a resource limitation in the cluster. |
|
BTW - I think the functional tests are failing due to a resource limitation (low memory) in the runner/cluster. The tests are reserving a huge amount of memory for SQL Server: Unfortunately we don't have logging for events, so we can't find the problem conclusively. See logs: SQL Server 2019 will run as non-root by default.
This container is running as user mssql.
To learn more visit https://go.microsoft.com/fwlink/?linkid=2099216.
2024-11-21 22:06:47.75 Server Setup step is copying system data file 'C:\templatedata\master.mdf' to '/var/opt/mssql/data/master.mdf'.
2024-11-21 22:06:47.77 Server Did not find an existing master data file /var/opt/mssql/data/master.mdf, copying the missing default master and other system database files. If you have moved the database location, but not moved the database files, startup may fail. To repair: shutdown SQL Server, move the master database to configured location, and restart.
2024-11-21 22:06:47.78 Server Setup step is copying system data file 'C:\templatedata\mastlog.ldf' to '/var/opt/mssql/data/mastlog.ldf'.
2024-11-21 22:06:47.78 Server Setup step is copying system data file 'C:\templatedata\model.mdf' to '/var/opt/mssql/data/model.mdf'.
2024-11-21 22:06:47.79 Server Setup step is copying system data file 'C:\templatedata\modellog.ldf' to '/var/opt/mssql/data/modellog.ldf'.
2024-11-21 22:06:47.80 Server Setup step is copying system data file 'C:\templatedata\msdbdata.mdf' to '/var/opt/mssql/data/msdbdata.mdf'.
2024-11-21 22:06:47.82 Server Setup step is copying system data file 'C:\templatedata\msdblog.ldf' to '/var/opt/mssql/data/msdblog.ldf'.
2024-11-21 22:06:47.82 Server Setup step is FORCE copying system data file 'C:\templatedata\model_replicatedmaster.mdf' to '/var/opt/mssql/data/model_replicatedmaster.mdf'.
2024-11-21 22:06:47.82 Server Setup step is FORCE copying system data file 'C:\templatedata\model_replicatedmaster.ldf' to '/var/opt/mssql/data/model_replicatedmaster.ldf'.
2024-11-21 22:06:47.83 Server Setup step is FORCE copying system data file 'C:\templatedata\model_msdbdata.mdf' to '/var/opt/mssql/data/model_msdbdata.mdf'.
2024-11-21 22:06:47.84 Server Setup step is FORCE copying system data file 'C:\templatedata\model_msdblog.ldf' to '/var/opt/mssql/data/model_msdblog.ldf'.
2024-11-21 22:06:47.87 Server Microsoft SQL Server 2019 (RTM-CU29-GDR) (KB5046860) - 15.0.4410.1 (X64)
Oct 23 2024 15:50:49
Copyright (C) 2019 Microsoft Corporation
Developer Edition (64-bit) on Linux (Ubuntu 20.04.6 LTS) <X64>
2024-11-21 22:06:47.87 Server UTC adjustment: 0:00
2024-11-21 22:06:47.87 Server (c) Microsoft Corporation.
2024-11-21 22:06:47.87 Server All rights reserved.
2024-11-21 22:06:47.87 Server Server process ID is 388.
2024-11-21 22:06:47.87 Server Logging SQL Server messages in file '/var/opt/mssql/log/errorlog'.
2024-11-21 22:06:47.88 Server Registry startup parameters:
-d /var/opt/mssql/data/master.mdf
-l /var/opt/mssql/data/mastlog.ldf
-e /var/opt/mssql/log/errorlog
2024-11-21 22:06:47.88 Server SQL Server detected 1 sockets with 2 cores per socket and 4 logical processors per socket, 4 total logical processors; using 4 logical processors based on SQL Server licensing. This is an informational message; no user action is required.
2024-11-21 22:06:47.88 Server SQL Server is starting at normal priority base (=7). This is an informational message only. No user action is required.
2024-11-21 22:06:47.88 Server Detected 12785 MB of RAM. This is an informational message; no user action is required.
2024-11-21 22:06:47.88 Server Using conventional memory in the memory manager.
2024-11-21 22:06:47.90 Server Page exclusion bitmap is enabled.
2024-11-21 22:06:47.92 Server Buffer pool extension is not supported on Linux platform.
2024-11-21 22:06:47.93 Server Buffer Pool: Allocating 2097152 bytes for 1995515 hashPages.
2024-11-21 22:06:48.01 Server Buffer pool extension is already disabled. No action is necessary.
2024-11-21 22:06:48.16 Server Successfully initialized the TLS configuration. Allowed TLS protocol versions are ['1.0 1.1 1.2']. Allowed TLS ciphers are ['ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-AES128-SHA256:ECDHE-ECDSA-AES256-SHA384:ECDHE-ECDSA-AES256-SHA:ECDHE-ECDSA-AES128-SHA:AES256-GCM-SHA384:AES128-GCM-SHA256:AES256-SHA256:AES128-SHA256:AES256-SHA:AES128-SHA:!DHE-RSA-AES256-GCM-SHA384:!DHE-RSA-AES128-GCM-SHA256:!DHE-RSA-AES256-SHA:!DHE-RSA-AES128-SHA'].
2024-11-21 22:06:48.18 Server Query Store settings initialized with enabled = 1,
2024-11-21 22:06:48.19 Server Node configuration: node 0: CPU mask: 0x000000000000000f:0 Active CPU mask: 0x000000000000000f:0. This message provides a description of the NUMA configuration for this computer. This is an informational message only. No user action is required.
2024-11-21 22:06:48.19 Server The maximum number of dedicated administrator connections for this instance is '1'
2024-11-21 22:06:48.20 Server Using dynamic lock allocation. Initial allocation of 2500 Lock blocks and 5000 Lock Owner blocks per node. This is an informational message only. No user action is required.
2024-11-21 22:06:48.21 Server In-Memory OLTP initialized on lowend machine.
2024-11-21 22:06:48.23 Server [INFO] Created Extended Events session 'hkenginexesession'
2024-11-21 22:06:48.23 Server Database Instant File Initialization: enabled. For security and performance considerations see the topic 'Database Instant File Initialization' in SQL Server Books Online. This is an informational message only. No user action is required.
ForceFlush is enabled for this instance.
2024-11-21 22:06:48.24 Server Total Log Writer threads: 2. This is an informational message; no user action is required.
2024-11-21 22:06:48.24 Server clwb is selected for pmem flush operation.
2024-11-21 22:06:48.25 Server Software Usage Metrics is disabled.
2024-11-21 22:06:48.26 spid9s [1]. Feature Status: PVS: 0. CTR: 0. ConcurrentPFSUpdate: 1.
2024-11-21 22:06:48.26 spid9s Starting up database 'master'.
ForceFlush feature is enabled for log durability.
2024-11-21 22:06:48.34 Server CLR version v4.0.30319 loaded.
2024-11-21 22:06:48.34 spid9s Converting database 'master' from version 897 to the current version 904.
2024-11-21 22:06:48.34 spid9s Database 'master' running the upgrade step from version 897 to version 898.
2024-11-21 22:06:48.35 spid9s Database 'master' running the upgrade step from version 898 to version 899.
2024-11-21 22:06:48.38 spid9s Database 'master' running the upgrade step from version 899 to version 900.
2024-11-21 22:06:48.38 spid9s Database 'master' running the upgrade step from version 900 to version 901.
2024-11-21 22:06:48.39 spid9s Database 'master' running the upgrade step from version 901 to version 902.
2024-11-21 22:06:48.40 spid9s Database 'master' running the upgrade step from version 902 to version 903.
2024-11-21 22:06:48.40 spid9s Database 'master' running the upgrade step from version 903 to version 904.
2024-11-21 22:06:48.59 spid9s Resource governor reconfiguration succeeded.
2024-11-21 22:06:48.60 spid9s SQL Server Audit is starting the audits. This is an informational message. No user action is required.
2024-11-21 22:06:48.60 spid9s SQL Server Audit has started the audits. This is an informational message. No user action is required.
2024-11-21 22:06:48.67 spid9s SQL Trace ID 1 was started by login "sa".
2024-11-21 22:06:48.68 spid9s Server name is 'sql-ctnr-bd5484bfc-84dtt'. This is an informational message only. No user action is required.
2024-11-21 22:06:48.68 spid23s Password policy update was successful.
2024-11-21 22:06:48.68 Server Common language runtime (CLR) functionality initialized.
2024-11-21 22:06:48.70 spid12s [32767]. Feature Status: PVS: 0. CTR: 0. ConcurrentPFSUpdate: 1.
2024-11-21 22:06:48.70 spid9s [4]. Feature Status: PVS: 0. CTR: 0. ConcurrentPFSUpdate: 1.
2024-11-21 22:06:48.71 spid12s Starting up database 'mssqlsystemresource'.
2024-11-21 22:06:48.72 spid9s Starting up database 'msdb'.
2024-11-21 22:06:48.72 spid12s The resource database build version is 15.00.4410. This is an informational message only. No user action is required.
2024-11-21 22:06:48.76 spid12s [3]. Feature Status: PVS: 0. CTR: 0. ConcurrentPFSUpdate: 1.
2024-11-21 22:06:48.76 spid12s Starting up database 'model'.
2024-11-21 22:06:48.77 spid23s A self-generated certificate was successfully loaded for encryption.
2024-11-21 22:06:48.78 spid23s Server is listening on [ 'any' <ipv6> 1433].
2024-11-21 22:06:48.79 spid23s Server is listening on [ 'any' <ipv4> 1433].
2024-11-21 22:06:48.80 Server Server is listening on [ ::1 <ipv6> 1434].
2024-11-21 22:06:48.80 Server Server is listening on [ 127.0.0.1 <ipv4> 1434].
2024-11-21 22:06:48.80 Server Dedicated admin connection support was established for listening locally on port 1434.
2024-11-21 22:06:48.80 spid23s Server is listening on [ ::1 <ipv6> 1431].
2024-11-21 22:06:48.81 spid23s Server is listening on [ 127.0.0.1 <ipv4> 1431].
2024-11-21 22:06:48.81 spid23s SQL Server is now ready for client connections. This is an informational message; no user action is required.
2024-11-21 22:06:48.82 spid9s Converting database 'msdb' from version 897 to the current version 904.
2024-11-21 22:06:48.82 spid9s Database 'msdb' running the upgrade step from version 897 to version 898.
2024-11-21 22:06:48.83 spid9s Database 'msdb' running the upgrade step from version 898 to version 899.
2024-11-21 22:06:48.84 spid12s Converting database 'model' from version 897 to the current version 904.
2024-11-21 22:06:48.84 spid12s Database 'model' running the upgrade step from version 897 to version 898.
2024-11-21 22:06:48.85 spid12s Database 'model' running the upgrade step from version 898 to version 899.
2024-11-21 22:06:48.85 spid9s Database 'msdb' running the upgrade step from version 899 to version 900.
2024-11-21 22:06:48.86 spid9s Database 'msdb' running the upgrade step from version 900 to version 901.
2024-11-21 22:06:48.86 spid12s Database 'model' running the upgrade step from version 899 to version 900.
2024-11-21 22:06:48.87 spid9s Database 'msdb' running the upgrade step from version 901 to version 902.
2024-11-21 22:06:48.87 spid12s Database 'model' running the upgrade step from version 900 to version 901.
2024-11-21 22:06:48.88 spid12s Database 'model' running the upgrade step from version 901 to version 902.
2024-11-21 22:06:48.88 spid12s Database 'model' running the upgrade step from version 902 to version 903.
2024-11-21 22:06:48.89 spid12s Database 'model' running the upgrade step from version 903 to version 904.
2024-11-21 22:06:48.94 spid12s Clearing tempdb database.
2024-11-21 22:06:49.02 spid12s [2]. Feature Status: PVS: 0. CTR: 0. ConcurrentPFSUpdate: 1.
2024-11-21 22:06:49.02 spid12s Starting up database 'tempdb'.
2024-11-21 22:06:49.15 spid12s The tempdb database has 1 data file(s).
2024-11-21 22:06:49.16 spid27s The Service Broker endpoint is in disabled or stopped state.
2024-11-21 22:06:49.16 spid27s The Database Mirroring endpoint is in disabled or stopped state.
2024-11-21 22:06:49.18 spid27s Service Broker manager has started.
2024-11-21 22:06:49.19 spid9s Database 'msdb' running the upgrade step from version 902 to version 903.
2024-11-21 22:06:49.19 spid9s Database 'msdb' running the upgrade step from version 903 to version 904.
2024-11-21 22:06:49.31 spid9s Recovery is complete. This is an informational message only. No user action is required.
2024-11-21 22:06:49.32 spid26s The default language (LCID 0) has been set for engine and full-text services.
2024-11-21 22:06:49.42 spid26s The tempdb database has 4 data file(s).
2024-11-21 22:07:24.55 spid9s SQL Server is terminating in response to a 'stop' request from Service Control Manager. This is an informational message only. No user action is required.
2024-11-21 22:07:24.99 spid27s Service Broker manager has shut down.
2024-11-21 22:07:24.99 spid9s .NET Framework runtime has been stopped.
2024-11-21 22:07:25.01 spid9s SQL Trace was stopped due to server shutdown. Trace ID = '1'. This is an informational message only; no user action is required.
|
superbeeny
force-pushed
the
features/superbeeny/postgreschart
branch
from
3377dc7 to
33a5958
Compare
superbeeny
temporarily deployed
to
publish-bicep
GitHub Actions
Inactive
kachawla
reviewed
Dec 11, 2024
| database: | ||
| image: ghcr.io/radius-project/mirror/postgres | ||
| tag: latest | ||
| storageClassName: "standard" # set to the storage class name if required |
There was a problem hiding this comment.
Would this need to change depending on where the Kubernetes cluster is hosted?
Comment on lines
+120
to
+127
| storageSize: "1Gi" | ||
| resources: | ||
| requests: | ||
| cpu: "2" | ||
| memory: "512Mi" | ||
| limits: | ||
| cpu: "2" | ||
| memory: "1024Mi" |
There was a problem hiding this comment.
Curious how did we decide these values. Would helpful if you could add a comment in the code for context as well.
There was a problem hiding this comment.
I'll add a comment here
kachawla
reviewed
Dec 11, 2024
| @@ -100,5 +100,21 @@ resource sqlContainer 'Applications.Core/containers@2023-10-01-preview' = { | |||
| } | |||
| } | |||
| } | |||
| runtimes: { | |||
There was a problem hiding this comment.
are we adding this to resolve the sqlserver functional test issues?
There was a problem hiding this comment.
this was an attempt to try and limit the size of the sqlserver, I'll revert in a subsequent commit
There was a problem hiding this comment.
This is a pretty large amount of resources still (2 GB). Did this help?
There was a problem hiding this comment.
@rynowak per our offline discussion, do we want to go ahead and delete this test? If so, @superbeeny can do this as part of this PR which will also unblock it.
For context, @superbeeny, we added a functional test for every portable resource type initially because we had custom implementation for each of them. Since then the implementation has evolved and majority of the code has converged across all types, so it is covered extensively through other functional tests. SQL server specifically is also covered in Radius eshop sample.
There was a problem hiding this comment.
+1 to the consensus that this is ok to remove. It think that would mean deleting https://github.com/radius-project/radius/blob/main/test/functional-portable/datastoresrp/noncloud/resources/sql_test.go and the other files it references.
There's actually more than one sql server test which is why I think we're hitting issues. That's 4gb minimum used by those tests.
kachawla
reviewed
Dec 11, 2024
There was a problem hiding this comment.
Thanks for driving this.
Couple of overall nits on pr/tracking logistics -
- Could you please update the PR title with a summary of the change?
- Could you add a checklist in External data store for Radius #8096 to include follow up tasks needed after this change. For example, documentation updates, analyzing dashboard for delta in resource consumption and documenting it if necessary.
superbeeny
changed the title
superbeeny
had a problem deploying
to
functional-tests
GitHub Actions
Failure
Signed-off-by: Nick Beenham <[email protected]>
Signed-off-by: Nick Beenham <[email protected]>
Signed-off-by: Nick Beenham <[email protected]>
Signed-off-by: Nick Beenham <[email protected]>
Signed-off-by: Nick Beenham <[email protected]>
Signed-off-by: Nick Beenham <[email protected]>
Signed-off-by: Nick Beenham <[email protected]>
Signed-off-by: Nick Beenham <[email protected]>
superbeeny
force-pushed
the
features/superbeeny/postgreschart
branch
from
33a5958 to
4117496
Compare
superbeeny
temporarily deployed
to
publish-bicep
GitHub Actions
Inactive
superbeeny
temporarily deployed
to
publish-bicep
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8072 +/- ##
==========================================
- Coverage 59.96% 59.95% -0.01%
==========================================
Files 589 589
Lines 39237 39237
==========================================
- Hits 23528 23525 -3
- Misses 13975 13977 +2
- Partials 1734 1735 +1 ☔ View full report in Codecov by Sentry. |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding Postgres installation to the Radius Helm chart
Type of change
Fixes: #8071
Updated issue: #8096
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: